Merge pull request #89 from mageplaza/2.4-develop

2.4 develop

Block/Adminhtml/Slider/Edit/Tab/Banner.php

@@ -196,6 +196,7 @@ protected function _prepareColumns()
             'validate_class' => 'validate-number validate-zero-or-greater validate-digits',
             'index' => 'position',
             'editable' => true,
+            'edit_only' => true,
         ]);
 
         return $this;

Block/Adminhtml/Slider/Edit/Tab/Design.php

@@ -159,7 +159,8 @@ protected function _prepareForm()
         $timeout = $fieldset->addField('autoplayTimeout', 'text', [
             'name' => 'autoplayTimeout',
             'label' => __('Autoplay Time-Out'),
-            'title' => __('Autoplay Time-Out')
+            'title' => __('Autoplay Time-Out'),
+            'class' => 'validate-number validate-zero-or-greater validate-digits',
         ]);
 
         $dependencies = $this->getLayout()->createBlock(Dependence::class)

composer.json

@@ -2,10 +2,10 @@
   "name": "mageplaza/module-banner-slider",
   "description": "Magento 2 Banner Slider extension",
   "require": {
-    "mageplaza/module-core": "^1.4.5"
+    "mageplaza/module-core": "^1.4.12"
   },
   "type": "magento2-module",
-  "version": "4.0.2",
+  "version": "4.0.3",
   "license": "proprietary",
   "authors": [
     {

view/adminhtml/web/template/grid/cells/html.html

@@ -1,24 +1,24 @@
-<!--
-/**
- * Mageplaza
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Mageplaza.com license that is
- * available through the world-wide-web at this URL:
- * https://www.mageplaza.com/LICENSE.txt
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade this extension to newer
- * version in the future.
- *
- * @category    Mageplaza
- * @package     Mageplaza_BannerSlider
- * @copyright   Copyright (c) Mageplaza (https://www.mageplaza.com/)
- * @license     https://www.mageplaza.com/LICENSE.txt
- */
--->
-
-<div class="data-grid-cell-content" html="$col.getLabel($row())" if="getType($row())"/>
-<img class="admin__control-thumbnail" attr="src: $col.getSrc($row()), alt: $col.getAlt($row())" ifnot="getType($row())"/>
+<!--
+/**
+ * Mageplaza
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Mageplaza.com license that is
+ * available through the world-wide-web at this URL:
+ * https://www.mageplaza.com/LICENSE.txt
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade this extension to newer
+ * version in the future.
+ *
+ * @category    Mageplaza
+ * @package     Mageplaza_BannerSlider
+ * @copyright   Copyright (c) Mageplaza (https://www.mageplaza.com/)
+ * @license     https://www.mageplaza.com/LICENSE.txt
+ */
+-->
+
+<div class="data-grid-cell-content" html="$col.getLabel($row())" if="getType($row())"></div>
+<img class="admin__control-thumbnail" attr="src: $col.getSrc($row()), alt: $col.getAlt($row())" ifnot="getType($row())"/>