My Account - Create wishlist UI

[revanth0212]

Description

Added the Create Wishlist logic.

Note: This feature is built ahead of the GQL support. Due to that, the create list mutation is not available and will be handled in PWA-989.

Note to @schensley: The mobile mocks had the buttons placed below the radio button group but since I am using the dialog component they are placed at the bottom. Do we have a standard that we would like to follow for all the mobile dialogs/drawers about where to place the buttons?

Related Issue

Closes PWA-629

Verification Stakeholders

@schensley

Verification Steps

1. On the deployed app go to /wishlist.
2. Click on the Create a List button.
3. Fill out the dialog.

Screenshots / Screen Captures (if appropriate)

Checklist

• I have added tests to cover my changes, if necessary.
• I have updated the documentation accordingly, if necessary.

[PWAStudioBot]

	Messages
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖	Associated JIRA tickets: PWA-989.

Generated by 🚫 dangerJS against 49d67ab

[schensley]

@revanth0212 this work looks really good. UX approved.

[larsroettig]

Why @function js doc ?

[revanth0212]

This is part of the new Docs initiate we have started for the code. I modeled this after @jcalcaben's previous PR. @jcalcaben is this as expected?

[jcalcaben]

@larsroettig this is used to help me auto-generate reference docs from the source code

@revanth0212 yes, this looks like the proper format

[larsroettig]

Empty root style ?

[tjwiebell]

Looks good, some suggestions to clean things up.

[tjwiebell]

Very odd, but I don't see listtype or sharing_code in the createWishlist mutation. If GraphQL does not support this field on creation, we should remove it.

[revanth0212]

I feel that looks like a mistake. sharing_code seems to be part of the WishList interface though, hence I would say, let's have it in the UX till the WishList feature is available through GQL.

[tjwiebell]

Please loop in the GraphQL team just in case we need to add list visibility as an input field; this looks perfect with current coverage though. Nice work 👍

[revanth0212]

Please loop in the GraphQL team just in case we need to add list visibility as an input field; this looks perfect with current coverage though. Nice work 👍

Thanks, @tjwiebell. I have created an issue on the architecture board asking this question.

[dpatil-magento]

@revanth0212 Please check below observations -

1. Per mocks Private radio should be first and Public below it, but app shows opposite, expected?
2. The entire Row is clickable, I think only the link should be clickable?

[revanth0212]

@revanth0212 Please check below observations -

1. Per mocks Private radio should be first and Public below it, but app shows opposite, expected?
2. The entire Row is clickable, I think only the link should be clickable?

Thanks for the check Dev. I have addressed the order of the radio buttons. Regarding the link, I haven't changed it and I think it is as expected.

[dpatil-magento]

@schensley Hope 2nd observations is expected?

[schensley]

@dpatil-magento @revanth0212
Regarding your question (2. above), ideally the entire area (row, button, container) should be clickable as it behaves in the demo. Provides for a much bigger target for the shopper.