Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/26156 luma theme banner css 1024px #30761

Conversation

chiranjeevi-cj
Copy link
Contributor

@chiranjeevi-cj chiranjeevi-cj commented Nov 3, 2020

Description (*)

  1. The Luma Theme Banner House CSS cleaned up when resolution above 1024px.

Fixed Issues (if relevant)

  1. Fixes The Luma Theme Banner House needs a lower margin when resolution above 1024px #26156

Manual testing scenarios (*)

  1. I tested in my local it's looking as expected.
    Screenshot from 2020-11-03 17-05-07

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 3, 2020

Hi @chiranjeevi-cj. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@chiranjeevi-cj
Copy link
Contributor Author

@magento give me test instance - deploy test instance based on PR changes

@magento-deployment-service
Copy link

Hi @chiranjeevi-cj. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@chiranjeevi-cj
Copy link
Contributor Author

@magento run all tests

@ghost ghost added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Nov 3, 2020
@ihor-sviziev ihor-sviziev self-assigned this Nov 3, 2020
@ihor-sviziev
Copy link
Contributor

Hi @chiranjeevi-cj,
Seems like the issue in the sample data module, as the issue related only to sample data and not reproducing on real catalog. As you did changes in luma - they seems not correct to me.

I see we already have Pull Request that does the correct fix in the sample data module magento/magento2-sample-data#146, so I'm closing this PR as not relevant.

Thank you so much for your contribution!

@m2-assistant
Copy link

m2-assistant bot commented Nov 3, 2020

Hi @chiranjeevi-cj, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost removed the Progress: review label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend duplicate Partner: EY partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Luma Theme Banner House needs a lower margin when resolution above 1024px
3 participants