-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tinyMCE migration 5to7 #876
base: develop
Are you sure you want to change the base?
Conversation
Before this gets processed, maybe the adobe guys can internally check what's going to happen in scope of magento/magento2#39252, it seems like you are going to downgrade TinyMCE again because the license of v7 is in violation with your open source software. |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @kadowakiverite,
Thanks for the contribution!
Due to the following issue:
We are rolling back the version. Once the issue is resolved, we will pick up this PR for further processing. In the meantime, we are moving this PR to On Hold
.
Thanks again!
Hello @engcom-Hotel, Thank you for the update! Best regards |
Description (*)
In TinyMCE 5, the toolbar font size option is referred to as
fontsizeselect
. However, in TinyMCE 7, this option has been renamed tofontsize
. This causes compatibility issues when migrating from TinyMCE 5 to TinyMCE 7 as the old toolbar configuration (fontsizeselect) no longer works in the new version.Checklist