Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinyMCE migration 5to7 #876

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kadowakiverite
Copy link

Description (*)

In TinyMCE 5, the toolbar font size option is referred to as fontsizeselect. However, in TinyMCE 7, this option has been renamed to fontsize. This causes compatibility issues when migrating from TinyMCE 5 to TinyMCE 7 as the old toolbar configuration (fontsizeselect) no longer works in the new version.

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@hostep
Copy link
Contributor

hostep commented Oct 16, 2024

Before this gets processed, maybe the adobe guys can internally check what's going to happen in scope of magento/magento2#39252, it seems like you are going to downgrade TinyMCE again because the license of v7 is in violation with your open source software.

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review October 21, 2024 06:36
Copy link
Collaborator

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kadowakiverite,

Thanks for the contribution!

Due to the following issue:

magento/magento2#39252

We are rolling back the version. Once the issue is resolved, we will pick up this PR for further processing. In the meantime, we are moving this PR to On Hold.

Thanks again!

@kadowakiverite
Copy link
Author

Hello @engcom-Hotel,

Thank you for the update!
I understand the situation and will wait until the issue is resolved.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Waiting Related PRs
Development

Successfully merging this pull request may close these issues.

4 participants