Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install dev dependencies by default #534

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ssx
Copy link

@ssx ssx commented Aug 8, 2022

Description

Fixed Issues (if relevant)

  1. magento/magento-cloud#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

@ssx ssx changed the title Don't install dev dependancies by default Don't install dev dependencies by default Aug 8, 2022
@ssx
Copy link
Author

ssx commented Oct 24, 2024

@aabumuslimov any chance of this being merged in? surely this is the sane default.

@aabumuslimov
Copy link

I think that makes sense since currently cloud deployment is not directly used in CI pipeline

@markshust
Copy link

markshust commented Nov 6, 2024

Additionally, the Commerce Cloud documentation suggests that we use the composer install --no-dev command, so this merge would make the code consistent with the docs. Per https://experienceleague.adobe.com/en/docs/commerce-operations/performance-best-practices/deployment-flow#install-dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants