Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output stderr when in debug mode #821

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

convenient
Copy link

@convenient convenient commented May 13, 2024

Some parts of the build process may output to stderr without failing the pipeline.

For example static content deploy does it here
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Deploy/Service/DeployPackage.php#L144-L147

If you have an issue that you want to debug and you set MIN_LOGGING_LEVEL: debug then I think it is unexpected that this data would not be present

Manual testing scenarios

The most obvious part of a deployment process that outputs to stderr would be the di compilation, when you do a deployment with this in place you should get more output there.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request introduces user-facing changes and includes meaningful updates for any required release notes and documentation changes
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Some parts of the build process may output to `stderr` without failing the pipeline.

For example static content deploy does it here 
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Deploy/Service/DeployPackage.php#L144-L147

If you have an issue that you want to debug and you set `MIN_LOGGING_LEVEL: debug` then I think it is unexpected that this data would not be present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants