Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jQuery to 3.5.0 #458

Merged
merged 7 commits into from
Feb 26, 2023
Merged

Conversation

karistom
Copy link
Contributor

@karistom karistom commented Feb 21, 2023

Updated jQuery to 3.5.0 to address the following issue.
#431
Whitesource vulnerability scan was run on the project. It showed mage having CVE-2020-11023 issue. This PR will fix the issue.

@perrito666
Copy link
Contributor

Hey, thank you for proposing this fix. The new jquery version seems to be the regular version despite its name indicating it is the minified version. We should use that version instead.

Copy link
Contributor

@perrito666 perrito666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace site/themes/learn/static/js/jquery-3.5.0.min.js with the actual minified version of it.

@karistom
Copy link
Contributor Author

@perrito666 the file has been updated.

@karistom
Copy link
Contributor Author

@perrito666 @natefinch would you please review and merge the PR? Thanks.

@perrito666 perrito666 merged commit 02bde0b into magefile:master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants