-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to oath-toolkit #26562
update to oath-toolkit #26562
Conversation
@@ -19,21 +20,36 @@ long_description The OATH Toolkit contains a shared library, command line \ | |||
the time-based TOTP algorithm. OATH is the Open \ | |||
AuTHentication organization which specify the algorithms. | |||
|
|||
homepage https://www.nongnu.org/oath-toolkit/ | |||
homepage http://oath-toolkit.nongnu.org/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URLs should be HTTPS
Commit messages should be of the format,
|
# Once upstream releases support for xmlsec 1.3+, none of this will be needed. | ||
conflicts_build-append \ | ||
xmlsec | ||
set xmlsec_lib ${prefix}/lib/xmlsec-1.2/lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why define a variable if you only use it once?
conflicts_build-append \ | ||
xmlsec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're telling the build to use xmlsec-1.2, why does it conflict with xmlsec?
master_sites savannah | ||
|
||
checksums rmd160 b1fb77b34fdf2459d0899a9fcb8e33f9b9485097 \ | ||
sha256 cafdf739b1ec4b276441c6aedae6411434bbd870071f66154b909cc6e2d9e8ba \ | ||
size 4706950 | ||
|
||
patch.pre_args-replace -p0 -p1 | ||
|
||
# Need to regenerate autotools scripts, due to previous patch; not needed for next release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which patch? The port doesn't have any and you haven't added one.
autoreconf.args -fvi | ||
|
||
# This version of 'oath-toolkit' requires 'xmlsec-1.2'. | ||
# Once upstream releases support for xmlsec 1.3+, none of this will be needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a good place to add the URL to the upstream bug report tracking xmlsec 1.3 support so that we can check on it in the future to see whether this workaround is still needed.
I already updated oath-toolkit to 2.6.12 in 7c3c1e1 and it builds fine on Sequoia. This patch seems to mistakenly revert those changes. |
Description
patches to fix Sequoia builds
see: https://trac.macports.org/ticket/70889
Portfile uploaded by yokuha fixes build issues on Sequoia
Type(s)
Tested on
macOS 14.7 23H124 arm64
Xcode 16.1 16B40
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?[skip notification]