-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup py38-{numpy, scipy} dependents #26223
base: master
Are you sure you want to change the base?
cleanup py38-{numpy, scipy} dependents #26223
Conversation
- drop py3{8,9} subports, add py312
- no dependents and upstream is gone
- no dependents in MacPorts, upstream archived the project, does not build anymore
- no dependents in MacPorts, last upstream release 8 years ago
- no dependents in MacPorts, last releast 6 years ago and project i unmaintained
- no dependents in MacPorts, still supported upstream but they haven't update the build system - does not build with modern Python versions due to removal of numpy.distutil.
[skip ci]
Notifying maintainers: |
I'm fine with this. I would have removed py38 in the near future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
For several ports, you changed replaced 38 with 312. It might have been better to also add 39, 310 and 311.
The fact that nobody has done so suggests to me that the port isn't actually very actively used. So if I add them now, likely it will be me to remove them again once another Python versions becomes EOL. If there is interest it can be done for sure, but I'd rather not do it blindly for all ports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for py-gacode
removal.
Approved for |
👍 |
Description
This PR contains the update and/or removal of PY38 subports of packages that require
py-numpy
and/orpy-scipy
. Both ports should be updated at some point to the latest upstream versions and removal of no-longer-supported subports will help in this (as it has shifted tomeson
as build system for the newer versions). Having only to worry about the upstream supported versions will make maintaining the port much easier.Type(s)
Tested on
macOS 15.0.1 24A348 x86_64
Xcode 16.0 16A242d
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?