Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup py38-{numpy, scipy} dependents #26223

Open
wants to merge 68 commits into
base: master
Choose a base branch
from

Conversation

reneeotten
Copy link
Contributor

Description

This PR contains the update and/or removal of PY38 subports of packages that require py-numpy and/or py-scipy. Both ports should be updated at some point to the latest upstream versions and removal of no-longer-supported subports will help in this (as it has shifted to meson as build system for the newer versions). Having only to worry about the upstream supported versions will make maintaining the port much easier.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.0.1 24A348 x86_64
Xcode 16.0 16A242d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

- drop py3{8,9} subports, add py312
- no dependents and upstream is gone
- no dependents in MacPorts, upstream archived the project, does not
  build anymore
- no dependents in MacPorts, last upstream release 8 years ago
- no dependents in MacPorts, last releast 6 years ago and project i
  unmaintained
- no dependents in MacPorts, still supported upstream but they haven't
  update the build system
- does not build with modern Python versions due to removal of
  numpy.distutil.
@macportsbot
Copy link

Notifying maintainers:
@Schamschula for port py-asdf-astropy, py-asdf-coordinates-schemas, py-asdf-standard, py-asdf-transform-schemas, py-asdf-unit-schemas, py-asdf, py-drms, py-gmic, py-metpy, py-npx, py-pygmsh, py-skyfield-data, py-skyfield, py-tropycal, py-vispy.
@michaelld for port py-commpy, py-scapy.
@ra1nb0w for port py-commpy, py-instrumentkit.
@smithsp for port py-gacode.
@joefowler for port py-silx.
@stromnov for port opencv4-devel, py-bcolz, py-blaze, py-blosc, py-bottleneck, py-deap, py-descartes, py-fiona, py-geopandas, py-imageio, py-imread, py-mahotas, py-networkit, py-numba, py-numexpr, py-odo, py-patsy, py-pygeos, py-pymvpa, py-scikit-image, py-snuggs, py-statsmodels.
@catap for port py-aubio, py-scapy, py-termplotlib, py-zbar.
@FlyingSamson for port py-ezdxf.
@jmroot for port py-game.
@jjstickel for port py-mayavi.
@cjones051073 for port py-scikit-hep-awkward, py-scikit-hep-awkward1, py-scikit-hep-boost-histogram, py-scikit-hep-hepstats, py-scikit-hep-hepunits, py-scikit-hep-hist, py-scikit-hep-mplhep, py-scikit-hep-mplhep_data, py-scikit-hep-particle, py-scikit-hep-uproot.
@mascguy for port opencv4-devel, opencv4.
@lpsinger for port py-astlib, py-astroplan, py-astropy-healpix, py-colormath, py-pyfftw, py-reproject, py-scikits-bootstrap.
@coquellen for port py-fabio.
@szhorvat for port py-igraph.
@nerdling for port py-igraph.
@bfarr for port py-kombine.
@GiovanniBussi for port py-mdtraj, py-mmtf-python, py-plumed.
@jswhit for port py-pygrib.
@MarcusCalhoun-Lopez for port py-pyside2.
@pmetzger for port py-pyside2.
@mojca for port py-sounddevice.
@eborisch for port py-gpilab-core, py-gpilab-examples, py-gpilab-framework, py-json-tricks, py-qimage2ndarray.

@Schamschula
Copy link
Contributor

I'm fine with this. I would have removed py38 in the near future.

@Schamschula Schamschula self-requested a review October 20, 2024 11:08
Copy link
Contributor

@Schamschula Schamschula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

For several ports, you changed replaced 38 with 312. It might have been better to also add 39, 310 and 311.

@reneeotten
Copy link
Contributor Author

Looks good overall!

For several ports, you changed replaced 38 with 312. It might have been better to also add 39, 310 and 311.

The fact that nobody has done so suggests to me that the port isn't actually very actively used. So if I add them now, likely it will be me to remove them again once another Python versions becomes EOL. If there is interest it can be done for sure, but I'd rather not do it blindly for all ports.

Copy link
Contributor

@smithsp smithsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for py-gacode removal.

@bfarr
Copy link
Contributor

bfarr commented Oct 21, 2024

Approved for py-kombine; thanks!

@cjones051073
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.