-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several updates - see individual commits #96
Open
fhgwright
wants to merge
12
commits into
macports:master
Choose a base branch
from
fhgwright:fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 14, 2024
-
Make darwin_c tests automatic.
These were only manual due to different build requirements. This adds a new "xtest" category, which is included in the automatic tests but meets the requirements for the darwin_c tests. TESTED: The darwin_c test are now included in the "test" target.
Configuration menu - View commit details
-
Copy full SHA for ac5464f - Browse repository at this point
Copy the full SHA ac5464fView commit details -
Rename MACPORTS_LEGACY_MIN_EARLY_SDK_ALLOWED
It's more consistent with normal naming conventions to use a leading underscore for the name of this flag. Thus, the flag is now _MACPORTS_LEGACY_MIN_EARLY_SDK_ALLOWED. Since this feature is only recently added and rarely needed, it's not too likely that this change will break anything. TESTED: Updated name has desired effect.
Configuration menu - View commit details
-
Copy full SHA for 18196ea - Browse repository at this point
Copy the full SHA 18196eaView commit details
Commits on Sep 25, 2024
-
Apple failed to update AvailabilityMacros.h for the 15.0 SDK, so it appears to be a 14.x SDK. This adds a workaround for that. TESTED: The checksdkversion test now reports correct results for all available SDKs (10.4-15.0).
Configuration menu - View commit details
-
Copy full SHA for 70e5250 - Browse repository at this point
Copy the full SHA 70e5250View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8808f1e - Browse repository at this point
Copy the full SHA 8808f1eView commit details -
Add scandir() compatibility feature.
This adds a wrapper to make the scandir() 'compar' argument and the provided alphasort() function match the types used in 10.8+, thereby avoiding warnings, and in some cases errors, due to the pointer type mismatch. To avoid breaking code expecting the old behavior, this hack is only applied when _MACPORTS_LEGACY_COMPATIBLE_SCANDIR is defined nonzero. Closes: https://trac.macports.org/ticket/70702 TESTED: Tests pass on all OS versions with this fix.
Configuration menu - View commit details
-
Copy full SHA for d31f7fa - Browse repository at this point
Copy the full SHA d31f7faView commit details
Commits on Sep 29, 2024
-
Add test for scandir() 'compar' type.
This tests for the pointer-type mismatch issue with the scandir() 'compar' arg. There are two versions, one verifying the expected old behavior, and another verifying the fix. See: https://trac.macports.org/ticket/70702 Also adds alphasort() and scandir() to the darwin_c tests. TESTED: Fails or gets warning on <10.8 without fix. Passes with fix.
Configuration menu - View commit details
-
Copy full SHA for fca9464 - Browse repository at this point
Copy the full SHA fca9464View commit details -
test_scandir: Add version with 32-bit inodes.
TESTED: Fails or gets warning on <10.8 without fix. Passes with fix.
Configuration menu - View commit details
-
Copy full SHA for a100f90 - Browse repository at this point
Copy the full SHA a100f90View commit details
Commits on Sep 30, 2024
-
Rewrite dprintf() implementation.
This is primarily to fix a bug in dprintf() which erroneously closed the fd after its use, but is also mildly more efficient. Based on some work by raf <[email protected]> TESTED: Passes the updated test, which failed before this fix.
Configuration menu - View commit details
-
Copy full SHA for d3019e5 - Browse repository at this point
Copy the full SHA d3019e5View commit details -
This performs a much more thorough test of dprintf(), including verifying that it does not close the underlying fd. TESTED: Fails when the old close bug is present, passes otherwise.
Configuration menu - View commit details
-
Copy full SHA for 40ecf77 - Browse repository at this point
Copy the full SHA 40ecf77View commit details -
Also rewrites dprintf() to be a wrapper around vdprintf(), rather than duplicating the "guts". Based on some work by raf <[email protected]> TESTED: Passes updated test.
Configuration menu - View commit details
-
Copy full SHA for e376493 - Browse repository at this point
Copy the full SHA e376493View commit details -
Add vdprintf() tests to dprintf() tests.
Also adds vdprintf() to darwin_c tests. TESTED: Fails without the new vdprintf() addition; passes with it.
Configuration menu - View commit details
-
Copy full SHA for 30ca4ff - Browse repository at this point
Copy the full SHA 30ca4ffView commit details -
[v]dprintf(): Fix unwanted lock release.
This uses a kludgy and nonportable method to avoid the ill effects of fclose() on locks (see the comment). It should be reliable for all relevant OSX versions, but it can be reverted if it causes trouble. TESTED: Passes tests, which would fail if the close() disable didn't work.
Configuration menu - View commit details
-
Copy full SHA for cacf14c - Browse repository at this point
Copy the full SHA cacf14cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.