Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several updates - see individual commits #96

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Commits on Sep 14, 2024

  1. Make darwin_c tests automatic.

    These were only manual due to different build requirements.  This
    adds a new "xtest" category, which is included in the automatic tests
    but meets the requirements for the darwin_c tests.
    
    TESTED:
    The darwin_c test are now included in the "test" target.
    fhgwright committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    ac5464f View commit details
    Browse the repository at this point in the history
  2. Rename MACPORTS_LEGACY_MIN_EARLY_SDK_ALLOWED

    It's more consistent with normal naming conventions to use a
    leading underscore for the name of this flag.  Thus, the
    flag is now _MACPORTS_LEGACY_MIN_EARLY_SDK_ALLOWED.
    
    Since this feature is only recently added and rarely needed, it's
    not too likely that this change will break anything.
    
    TESTED:
    Updated name has desired effect.
    fhgwright committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    18196ea View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Fix broken 15.x SDK version

    Apple failed to update AvailabilityMacros.h for the 15.0 SDK, so it
    appears to be a 14.x SDK.  This adds a workaround for that.
    
    TESTED:
    The checksdkversion test now reports correct results for all available
    SDKs (10.4-15.0).
    fhgwright committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    70e5250 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8808f1e View commit details
    Browse the repository at this point in the history
  3. Add scandir() compatibility feature.

    This adds a wrapper to make the scandir() 'compar' argument and the
    provided alphasort() function match the types used in 10.8+, thereby
    avoiding warnings, and in some cases errors, due to the pointer type
    mismatch.
    
    To avoid breaking code expecting the old behavior, this hack is only
    applied when _MACPORTS_LEGACY_COMPATIBLE_SCANDIR is defined nonzero.
    
    Closes: https://trac.macports.org/ticket/70702
    
    TESTED:
    Tests pass on all OS versions with this fix.
    fhgwright committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d31f7fa View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Add test for scandir() 'compar' type.

    This tests for the pointer-type mismatch issue with the scandir()
    'compar' arg.  There are two versions, one verifying the expected old
    behavior, and another verifying the fix.
    
    See: https://trac.macports.org/ticket/70702
    
    Also adds alphasort() and scandir() to the darwin_c tests.
    
    TESTED:
    Fails or gets warning on <10.8 without fix.  Passes with fix.
    fhgwright committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    fca9464 View commit details
    Browse the repository at this point in the history
  2. test_scandir: Add version with 32-bit inodes.

    TESTED:
    Fails or gets warning on <10.8 without fix.  Passes with fix.
    fhgwright committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    a100f90 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Rewrite dprintf() implementation.

    This is primarily to fix a bug in dprintf() which erroneously closed
    the fd after its use, but is also mildly more efficient.
    
    Based on some work by raf <[email protected]>
    
    TESTED:
    Passes the updated test, which failed before this fix.
    fhgwright committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d3019e5 View commit details
    Browse the repository at this point in the history
  2. Rewrite dprintf() test.

    This performs a much more thorough test of dprintf(), including
    verifying that it does not close the underlying fd.
    
    TESTED:
    Fails when the old close bug is present, passes otherwise.
    fhgwright committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    40ecf77 View commit details
    Browse the repository at this point in the history
  3. Add vdprintf() support.

    Also rewrites dprintf() to be a wrapper around vdprintf(), rather than
    duplicating the "guts".
    
    Based on some work by raf <[email protected]>
    
    TESTED:
    Passes updated test.
    fhgwright committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e376493 View commit details
    Browse the repository at this point in the history
  4. Add vdprintf() tests to dprintf() tests.

    Also adds vdprintf() to darwin_c tests.
    
    TESTED:
    Fails without the new vdprintf() addition; passes with it.
    fhgwright committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    30ca4ff View commit details
    Browse the repository at this point in the history
  5. [v]dprintf(): Fix unwanted lock release.

    This uses a kludgy and nonportable method to avoid the ill effects of
    fclose() on locks (see the comment).  It should be reliable for all
    relevant OSX versions, but it can be reverted if it causes trouble.
    
    TESTED:
    Passes tests, which would fail if the close() disable didn't work.
    fhgwright committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    cacf14c View commit details
    Browse the repository at this point in the history