Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib): generate same code on big-endian platforms #431

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix(lib): generate same code on big-endian platforms #431

merged 2 commits into from
Oct 17, 2024

Conversation

0x2a-42
Copy link
Contributor

@0x2a-42 0x2a-42 commented Oct 15, 2024

Fix for #427. I verified that the test fails in the same way as in the linked issue, when to_be_bytes is used instead, so this must have been the only portability issue that is detected by existing tests.

@jeertmans
Copy link
Collaborator

Impressive @0x2a-42! Can you check this @LecrisUT ?

@LecrisUT
Copy link
Contributor

Thanks a lot @0x2a-42 for looking into this ❤️! I am rebasing #428 on top of your branch, and I will report in 30 min if it works right

@LecrisUT LecrisUT mentioned this pull request Oct 16, 2024
Closed
LecrisUT
LecrisUT approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the builder and can confirm that it works fine with this PR 🙂

@jeertmans jeertmans added the bug Something isn't working label Oct 16, 2024
@jeertmans jeertmans linked an issue Oct 16, 2024 that may be closed by this pull request
logos-codegen test failure in s390x #427
Closed
@jeertmans
Copy link
Collaborator

Ran the builder and can confirm that it works fine with this PR 🙂

Thanks for checking!

@jeertmans
Copy link
Collaborator

Thanks for your contribution!

@jeertmans jeertmans merged commit 3c81ceb into maciejhirsz:master Oct 17, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeertmans jeertmans jeertmans left review comments

@LecrisUT LecrisUT LecrisUT approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logos-codegen test failure in s390x
3 participants
@0x2a-42 @jeertmans @LecrisUT