-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to regenerate catalog_upload.json
files
#200
Add script to regenerate catalog_upload.json
files
#200
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
catalog_upload.json
files
Add helper script to regenerate the catalog_upload.json file(s) from the *.yaml files that are found inside the locally cloned katalog repo. Regenerate files: - bootstrapper/catalog_upload.json - quickstart/catalog_upload.json Current caveats: - no documentation yet - no command parameters, no command line help - the user must have cloned the katalog repo and the mlx repo in the same parent folder (in the future those paths should be configurable as parameters) - not all of the YAML files in the katalog repo may want to be included in the catalog upload, so after the files get regenerated, the user (MLX maintainer) needs to exercise some judgment - assets that live outside the katalog repo will not be found and have to be re-added (or not removed) using a Git enabled IDE or git diff tool - this initial commit reorders some of the assets (based on filename) Signed-off-by: Christian Kadner <[email protected]>
22886ea
to
9201347
Compare
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
15244ad
to
14a1b51
Compare
@Tomcli -- this PR adds the new katalog assets for CodeNet, Qiskit and MAX models. It will also help to take care of future katalog updates with a new script. |
/lgtm |
Thanks @Tomcli |
I will address (some of) the current caveats listed above in a separate PR: #222
|
It is becoming difficult to maintain the catalog upload files for the Bootstrapper and the Quickstart with Docker Compose.
This PR adds a helper script to regenerate the
catalog_upload.json
file(s) from the YAML files that are found inside the clonedkatalog
repo.Current caveats:
katalog
repo and themlx
repo in the same parent folder (in the future those paths should be configurable as parameters)katalog
repo may want to be included in the catalog upload, so after the files get regenerated, the user (MLX maintainer) needs to excercise some judgmentkatalog
repo will not be found and have to be re-added (or not removed) using a Git enabled IDE or git diff toolVerify all URLs are valid:
Signed-off-by: Christian Kadner [email protected]