Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNI-308 Payment instructions length #765

Merged
merged 2 commits into from
Oct 24, 2023
Merged

UNI-308 Payment instructions length #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e11ddf
Remove maxLength restrictions from product paymentInstructions and de…
konker Oct 24, 2023
854c907
Version 20.6.0
konker Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion maas-schemas/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "maas-schemas",
"version": "20.5.0",
"version": "20.6.0",
"description": "Schemas for MaaS infrastructure",
"main": "index.js",
"engine": {
Expand Down
4 changes: 1 addition & 3 deletions maas-schemas/schemas/core/product.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
},
"description": {
"type": "string",
"minLength": 1,
"maxLength": 255
"minLength": 1
},
"icon": {
"type": "string",
Expand Down Expand Up @@ -43,7 +42,6 @@
"paymentInstruction": {
"type": "string",
"minLength": 1,
"maxLength": 255,
"description": "A product may define a text to be shown in Detailed Pricing segment, due to regulatory or partner mandated requirement. This is informed by product.paymentInstruction object, containing localized text string"
}
},
Expand Down
4 changes: 0 additions & 4 deletions maas-schemas/src/io-ts/_translation.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1194,8 +1194,6 @@ INFO: primitive type "string" used outside top-level definitions
in schemas/core/product.json
WARNING: minLength field not supported outside top-level definitions
in schemas/core/product.json
WARNING: maxLength field not supported outside top-level definitions
in schemas/core/product.json
INFO: primitive type "string" used outside top-level definitions
in schemas/core/product.json
WARNING: minLength field not supported outside top-level definitions
Expand All @@ -1216,8 +1214,6 @@ INFO: primitive type "string" used outside top-level definitions
in schemas/core/product.json
WARNING: minLength field not supported outside top-level definitions
in schemas/core/product.json
WARNING: maxLength field not supported outside top-level definitions
in schemas/core/product.json
INFO: missing description
in schemas/core/product.json
INFO: missing description
Expand Down