Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📓 Add README and example without pyqg #15

Merged
merged 2 commits into from
Nov 7, 2024
Merged

📓 Add README and example without pyqg #15

merged 2 commits into from
Nov 7, 2024

Conversation

asross
Copy link
Collaborator

@asross asross commented May 23, 2023

Addresses #10, #5, #9, and #6, superseding #11.

@asross asross requested a review from jdenholm May 23, 2023 13:26
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dorchard dorchard self-requested a review May 24, 2023 21:11
@dorchard
Copy link
Collaborator

Hi @asross - I found that just doing import eqn_disco wasn't working for me in the notebook because eqn_disco does not itself export the sub modules util etc. My solution is in this commit ef2fd0d that way you can just do import eqn_disco as in your notebooks and get access to eqn_disco.util... etc. is that okay?

@dorchard
Copy link
Collaborator

@asross bump on the above - does my addition work okay for you?

@asross
Copy link
Collaborator Author

asross commented Feb 1, 2024

@dorchard Apologies for the late reply, just seeing this for some reason! Your change works for me 👍

@dorchard
Copy link
Collaborator

dorchard commented Feb 1, 2024

Okay that's great! There are a few other comments from me above. Can you take a look then I can approve.

@asross
Copy link
Collaborator Author

asross commented Feb 5, 2024

@dorchard not seeing the comments you mentioned above -- can you point me to them?

@dorchard dorchard merged commit 76cfd3c into dev Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants