updates and fixes

m-m-m · Feb 12, 2024 · 22f01b8 · 22f01b8
1 parent 84f0884
commit 22f01b8
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 21 deletions.
diff --git a/api/pom.xml b/api/pom.xml
@@ -22,6 +22,11 @@
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-junit-jupiter</artifactId>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
 </project>
diff --git a/java/impl/pom.xml b/java/impl/pom.xml
@@ -64,6 +64,7 @@
           <executable>mvn</executable>
           <workingDirectory>${maven.test.path}</workingDirectory>
           <arguments>
+            <argument>-X</argument>
             <argument>install</argument>
           </arguments>
         </configuration>

diff --git a/...test/java/io/github/mmm/code/impl/java/JavaExtendedContextWithMavenAndSourceCodeTest.java b/...test/java/io/github/mmm/code/impl/java/JavaExtendedContextWithMavenAndSourceCodeTest.java
@@ -61,7 +61,7 @@ public void testBasics() {
     assertThat(source.getSource()).isSameAs(source);
 
     List<? extends CodeSource> dependencies = source.getDependencies().getDeclared();
-    assertThat(dependencies).hasSize(5);
+    assertThat(dependencies).hasSize(4);
     CodeSource compileDependency = dependencies.get(0);
     verifyDependency(compileDependency, "target/classes", "src/main/java", "compile");
     assertThat(source.getParent()).isSameAs(compileDependency);

diff --git a/java/maven/pom.xml b/java/maven/pom.xml
@@ -13,15 +13,10 @@
   <name>${project.artifactId}</name>
   <description>Integration with Maven.</description>
 
-  <properties>
-    <maven.version>3.6.1</maven.version>
-  </properties>
-
   <dependencies>
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-core</artifactId>
-      <version>${maven.version}</version>
     </dependency>
     <dependency>
       <groupId>${project.groupId}</groupId>

diff --git a/java/maven/src/test/java/io/github/mmm/code/java/maven/impl/MavenBridgeImplTest.java b/java/maven/src/test/java/io/github/mmm/code/java/maven/impl/MavenBridgeImplTest.java
@@ -50,7 +50,7 @@ public void testReadModel() {
     assertThat(model.getParent().getGroupId()).isEqualTo(groupId);
     assertThat(model.getParent().getVersion()).isEqualTo("${revision}");
     verifyDependencies(model, DependencyHelper.create(PROJECT_GROUP_ID, "mmm-code-base", null),
-        DependencyHelper.create("org.apache.maven", "maven-core", "${maven.version}"));
+        DependencyHelper.create("org.apache.maven", "maven-core", null));
   }
 
   /**
@@ -89,11 +89,10 @@ public void testReadProject() {
     assertThat(model.getGroupId()).isEqualTo(groupId);
     assertThat(model.getVersion()).matches(VERSION_PATTERN);
     verifyDependencies(model, DependencyHelper.create(groupId, "mmm-code-base", "*"),
-        DependencyHelper.create("org.apache.maven", "maven-core", "3.6.1"),
-        DependencyHelper.create("org.assertj", "assertj-core", "3.24.2", SCOPE_TEST),
-        DependencyHelper.create("org.junit.jupiter", "junit-jupiter", "5.9.3", SCOPE_TEST),
-        DependencyHelper.create("org.mockito", "mockito-junit-jupiter", "4.9.0", SCOPE_TEST),
-        DependencyHelper.create("ch.qos.logback", "logback-classic", "1.4.5", SCOPE_TEST));
+        DependencyHelper.create("org.apache.maven", "maven-core", "3.9.6"),
+        DependencyHelper.create("org.assertj", "assertj-core", "3.25.3", SCOPE_TEST),
+        DependencyHelper.create("org.junit.jupiter", "junit-jupiter", "5.10.2", SCOPE_TEST),
+        DependencyHelper.create("ch.qos.logback", "logback-classic", "1.4.14", SCOPE_TEST));
   }
 
   private void verifyDependencies(Model model, Dependency... dependencies) {

diff --git a/pom.xml b/pom.xml
@@ -16,6 +16,7 @@
   <properties>
     <java.version>17</java.version>
     <mmm.repository>code</mmm.repository>
+    <maven.version>3.9.6</maven.version>
   </properties>
 
   <modules>
@@ -24,14 +25,6 @@
     <module>java</module>
   </modules>
 
-  <dependencies>
-    <dependency>
-      <groupId>org.mockito</groupId>
-      <artifactId>mockito-junit-jupiter</artifactId>
-      <version>4.9.0</version>
-      <scope>test</scope>
-    </dependency>
-  </dependencies>
   <dependencyManagement>
     <dependencies>
       <!-- BOM of mmm-scanner -->
@@ -42,7 +35,16 @@
         <type>pom</type>
         <scope>import</scope>
       </dependency>
-
+      <dependency>
+        <groupId>org.apache.maven</groupId>
+        <artifactId>maven-core</artifactId>
+        <version>${maven.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>org.mockito</groupId>
+        <artifactId>mockito-junit-jupiter</artifactId>
+        <version>5.10.0</version>
+      </dependency>
       <!-- Internal dependencies -->
       <dependency>
         <groupId>${project.groupId}</groupId>