FIX: incus_storage_bucket produces inconsistent result #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h current config state for Storage Bucket Signed-off-by: Fabian Mettler <[email protected]>
|
We can probably share some of that logic with the volume issue we have open as both are basically the same where volume.XYZ keys set on the pool will propagate to new volumes or buckets. |
|
So basically it's safe to ignore any key the user didn't define so long as the key and value line up with the matching volume.XYZ key on the pool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the situation where
incus_storage_bucketproduces an inconsistent result when using thelvmstorage driver, see #47.The same solution is already used in other resources, e.g: