Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new block's page property #418

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

hbugdoll
Copy link
Member

@hbugdoll hbugdoll commented Apr 5, 2024

What are you changing/introducing

  • Added page property for blocks in both admin and frontend context as a replacement for getEnvOption('pageObject') resp. getPageObject(), which is now deprecated
  • Added new unit test testPageObjectPlaceholderIteration() and therefore TestingPageObjectBlock
  • Fixed typo in test names:
    • testConcretImplementation() testConcreteImplementation()
    • ConcretImplementationBlockConcreteImplementationBlock

What is the reason for changing/introducing

QA

Q A
Is bugfix? no
New feature? yes
Breaks BC? no
Tests pass? yes
Fixed issues

@hbugdoll
Copy link
Member Author

hbugdoll commented Apr 5, 2024

New unit test was added.
In case of frontend context the page object data is simplified in renderFrontend() before stringification, which is needed because of the internal processing of renderPlaceholder().

Updates to guide will be done afterwards...

Copy link
Member

@nadar nadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in generel, we have to discuss this change because the interfaces changes, which is a clear BC break, and must be released along with 6.0

src/base/BlockInterface.php Outdated Show resolved Hide resolved
src/base/BlockInterface.php Outdated Show resolved Hide resolved
@hbugdoll
Copy link
Member Author

hbugdoll commented Apr 6, 2024

in generel, we have to discuss this change because the interfaces changes, which is a clear BC break, and must be released along with 6.0

I assumed that a minor release can deal with that BC break along with the deprecated annotation.
Ok, then introduction with version 6.0.
Can we then drop the getEnvOption('pageObject') & getPageObject() immediately or only later with version 7.0 ?

@nadar
Copy link
Member

nadar commented Apr 20, 2024

I assumed that a minor release can deal with that BC break along with the deprecated annotation.

no, if someone implement that interface this will break the application

Can we then drop the getEnvOption('pageObject') & getPageObject() immediately or only later with version 7.0 ?

It would be better to first trigger deprecation notices, its better migration path for developers 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants