Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed block group extra attribute sorting issue #410

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Fixed block group extra attribute sorting issue #410

merged 3 commits into from
Feb 21, 2024

Conversation

hbugdoll
Copy link
Member

What are you changing/introducing

  • Make block groups' extra attribute groupLabel non-sortable

What is the reason for changing/introducing

  • Sorting by Group (groupLabel) in Groups Management table raises a SQL error:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'groupLabel' in 'order clause'
The SQL being executed was: SELECT * FROM `cms_block_group` WHERE `cms_block_group`.`is_deleted`=FALSE ORDER BY `groupLabel` LIMIT 25

Bildschirmfoto 2024-02-20 um 23 31 25

QA

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues

@nadar nadar merged commit 1086b5b into luyadev:master Feb 21, 2024
8 checks passed
@hbugdoll hbugdoll deleted the blockgroup-fix branch February 22, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants