Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure the listen address of the service #695

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

taik0
Copy link
Contributor

@taik0 taik0 commented Oct 23, 2023

(defaults to 0.0.0.0).

krakend/krakend-ce#803

@taik0 taik0 changed the title Allow to configure the listen address of the service (defaults to 0.0… Allow to configure the listen address of the service Oct 23, 2023
Signed-off-by: Daniel Ortiz <[email protected]>
@taik0 taik0 requested a review from kpacha October 23, 2023 12:15
Copy link
Contributor

@dhontecillas dhontecillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a small comment.

config/config.go Outdated Show resolved Hide resolved
@kpacha kpacha merged commit 20a22f6 into master Oct 26, 2023
5 checks passed
@kpacha kpacha deleted the listen_address branch October 26, 2023 12:02
Copy link

This pull request was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants