Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated URL params parsing #419

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alerque
Copy link
Member

@alerque alerque commented Nov 9, 2023

See discussion begun in in #418

@alerque alerque requested a review from catwell November 9, 2023 11:41
@alerque
Copy link
Member Author

alerque commented Nov 9, 2023

Is this what you had in mind @catwell?

Should this be considered a breaking change? That might affect what our next version number is.

Besides stopping to document this as a feature we should probably document the removal too.

@catwell
Copy link
Member

catwell commented Nov 9, 2023

@alerque Yes, I had no idea it would be so impacting. It might be considered a breaking change but I would be surprised if people relied on this behavior. Tools typically implement the newer behavior e.g.:

$ trurl -g "{path"} "ftp://root:[email protected]/pub/virus.exe;type=i"
/pub/virus.exe;type=i

And by the way trurl which is a good reference considers empty paths to be /.

$ trurl -g "{path"} "https://foo.bar?foo=bar"
/

@alerque
Copy link
Member Author

alerque commented Nov 9, 2023

Also just for reference, the RFC that standardized params was 1995 and the RFC that obsoleted it with no mention of params was 2005.

I'm not too worried about dropping it without much ado, but we should still be careful. This library is used a lot of places and I want to keep the friction of updating to a minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants