feat: Add swHasUpgrade but prevent auto reload. #517
Conversation
…grade and reload of service worker
|
Task linked: DEV-11966 Remove additional page reload |
Deployed with Cloudflare Pages ☁️ 🚀 🆗 |
app.vue
Outdated
| newWorker.addEventListener('statechange', () => { | ||
| if (newWorker.state === 'activated') { | ||
| // Notify the user that an update is available | ||
| console.log('A new version is available. Please refresh.') |
There was a problem hiding this comment.
from what I can see this is just logging on the console log and not really notifying the user. If he doesnt open the devtools he wouldn't know that he needs to refresh the page to get the update right?
There was a problem hiding this comment.
That was for debugging. Removing.
app.vue
Outdated
| }) | ||
| const hasUpgrade = ref<boolean>(false) |
There was a problem hiding this comment.
Let's name it hasServiceWorkerUpgrade and move to the top where all refs sit.
Also qq, would that also work if we wrap the below code into function and call in onMounted hook as setupServiceWorker?
nuxt.config.ts
Outdated
| path: '~/node_modules/vue-instantsearch/src/components', | ||
| sourcemap: true, | ||
| }, // Enable source map generation for components | ||
| { | ||
| path: '~/node_modules/vite-plugin-vue-inspector/src', | ||
| sourcemap: true, | ||
| }, // Enable source map generation for components | ||
| { | ||
| path: '~/node_modules/@vite-pwa/nuxt/dist/runtime/components', | ||
| sourcemap: true, | ||
| }, // Enable source map generation for components |
There was a problem hiding this comment.
qq, do we need the source maps for this node_modules?
There was a problem hiding this comment.
Ok the sourcemaps are good to have, but it turns out nuxt prepare is reading this section and for example "pages" will crash because the route names are not defined and will by default be defined as the concat of the path names which ends up using symbol names like 404 (which is a number) or [profileAddress]BuyLyx which is obviously not a good symbol name. I removed pages and some of the other one. Each component that could possibly cause errors at runtime is nice to have because when an error occurs then sentry will show the actual source code rather than just minified javascript garbage. But obviously none of this is like "oh my god, there are no symbols" :)
|
@richtera we are getting there, can you check why lint is complaining? |
See above comment about "pages" |
Ticket ID
https://app.clickup.com/t/2645698/DEV-11966
Description
provide a new boolean called swHasUpgrade using provide('swHasUpgrade', hasUpgrade)
the value will be set if an upgrade is detected during the initial page load. The upgrade will be allowed,
but the new version will not be initialized such that we can notify the user they can reload to get an upgrade
next time. It should automatically upgrade on the next full navigation to another page anyways.