feat: parser refactor and updates #505
Open
+1,002
−598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersalprofile.cloud into twitter-parser-updates
nastita
changed the title
|
Task linked: DEV-11851 X (Twitter): allow different type of input |
Deployed with Cloudflare Pages ☁️ 🚀 🆗 |
dzbo
reviewed
Oct 22, 2024
…file.cloud into twitter-parser-updates
dzbo
approved these changes
Oct 30, 2024
|
Seem like it doesn't work for just a profile name: 
due to cors policy kick in, Non browser request works fine: I wonder if we could proxy this through our API, thoughts @richtera ? Also, for X we can skip oembed as it's straight forward to parse their embed. Should we just use oembed when we really need? |
|
Task linked: DEV-11989 Prevent SoundCloud autoplay |
dzbo
requested changes
Nov 3, 2024
| matches = Array.from(input.matchAll(regex)) | ||
| } else { | ||
| const match = input.match(regex) | ||
| console.log(JSON.stringify(match)) |
There was a problem hiding this comment.
Let's not use console.log, we have own logging mechanism:
if (gridLog.enabled) {
gridLog(JSON.stringify(match))
}…file.cloud into twitter-parser-updates
…file.cloud into twitter-parser-updates
richtera
approved these changes
Nov 4, 2024
| regexWithCallbacks: [ | ||
| // Match whole embed code | ||
| { | ||
| regex: createIframeRegex('https:\\/\\/warpcast\\.com\\/(?<id>[\\w.-]+)'), |
There was a problem hiding this comment.
Ideally it should be ```console
- 16 characters or fewer
- Latin alphabet, numbers or dash (
-) - Cannot start with a dash
- Must end in (
.eth), i.e. ENS-compatible names like[cb.id](http://cb.id/)aren’t supported at this time - Not supported at this time:
- subdomains, e.g.
abc.test.eth - DNS to ENS
- subdomains, e.g.
So maybe something like `\\/(?<id>[a-z0-9][a-z0-9-.]{0,15}$)`. They don't actually support unicode or other chars. Only a-z0-9 and - it seems. Although the "." in the name is not in the offficial docs although they say that ENS names work and they obviously require a dot. I suppose invalid names would just end up with an error page and should not be that bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket ID
DEV-11851
DEV-11989
Description
Enhancements for other platforms will come in follow up prs