feat: profile fetching #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…universalprofile.cloud into chore/setup-DEV-6010
…ofile.cloud into feat/dashboard-screen-DEV-5746
…ofile.cloud into feat/profile-fetching-DEV-6309
richtera
requested changes
Aug 3, 2023
package.json
Outdated
| @@ -69,7 +71,7 @@ | |||
| "stylelint-scss": "5.0.1", | |||
| "typescript": "5.1.6", | |||
| "util": "0.12.5", | |||
| "web3": "^4.0.3", | |||
| "web3": "^1.10.0", | |||
There was a problem hiding this comment.
I this says ^1.10.0 then it will not force 4.0.3 to downgrade. You should use either ~1.10.0 or 1.10.x. It will cause devs to have to rm -rf node_modules && yarn in some cases.
richtera
approved these changes
Aug 3, 2023
Hugoo
approved these changes
Aug 3, 2023
package.json
Outdated
| @@ -25,8 +25,10 @@ | |||
| "test:debug": "npx playwright test --debug" | |||
| }, | |||
| "devDependencies": { | |||
| "@erc725/erc725.js": "^0.17.2", | |||
shared/config.ts
Outdated
Comment on lines
8
to
15
| rpcHttp: 'https://rpc.testnet.lukso.network', | ||
| ipfsUrl: 'https://2eff.lukso.dev/ipfs/', | ||
| }, | ||
| { | ||
| id: 'mainnet', | ||
| name: 'LUKSO Mainnet', | ||
| chainId: '0x2a', | ||
| rpcHttp: 'https://rpc.mainnet.lukso.network', |
There was a problem hiding this comment.
shall we use this or gateway.fm ?
|
|
||
| web3Instances.value = { | ||
| ...web3Instances.value, | ||
| [providerName]: markRaw(web3), // web3 instances must be stored as raw objects to prevent reactivity issues |
utils/validateLSP4Metadata.ts
Outdated
| import { LSP4DigitalAssetJSON } from '@lukso/lsp-factory.js/build/main/src/lib/interfaces/lsp4-digital-asset' | ||
|
|
||
| export const validateLSP4MetaData = ( | ||
| LSP4MetadataJSON: any |
There was a problem hiding this comment.
Any or Record<string, any> maybe?
utils/validateLSP4Metadata.ts
Outdated
Comment on lines
6
to
9
| let images = [[]] | ||
| let links = [] | ||
| let assets = [] | ||
| let icon = [] |
There was a problem hiding this comment.
we dont have types for these? (i dont remember if we created some types in one of our libs)
| @@ -1,4 +1,5 @@ | |||
| import { isAddress } from 'web3-validator' | |||
| import web3utils from 'web3-utils' | |||
| const { isAddress } = web3utils // need to import like this due to CommonJS module import issue | |||
…ofile.cloud into feat/profile-fetching-DEV-6309
Deployed with Cloudflare Pages ☁️ 🚀 🆗 |
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket ID
DEV-6309
DEV-6529
Description