chore: wallet setup #25
Conversation
…universalprofile.cloud into chore/setup-DEV-6010
|
don't you want to push this to the default branch instead (develop)? |
Yeah, I will push this to |
|
Hmmm. do we need this? 
|
| /.output | ||
| /public/assets/fonts | ||
| /functions | ||
| /translations/ |
There was a problem hiding this comment.
it might be missing a .yarn here too?
There was a problem hiding this comment.
You cannot include .yarn here. Look at the universalprofile-extension repo and copy the yarn thing there or look at the docs. Without .yarn/plugins and .yarn/releases it will revert to yarn classic. The yarn 3 docs also have this documented.
There was a problem hiding this comment.
I guess here it's fine, we don't want to lint .yarn folder :D
nuxt.config.ts
Outdated
| plausible: { | ||
| domain: 'migrate.lukso.network', | ||
| }, |
There was a problem hiding this comment.
This is not relevant anymore. We can remove it.
There was a problem hiding this comment.
Ah right domain is wrong, we not planning to use plausible for wallet?
| "lint:fmt": "prettier --check --log-level=warn .", | ||
| "lint:fmt:fix": "prettier --write .", | ||
| "lint:types": "tsc --noEmit --project tsconfig.json", | ||
| "prepare": "husky install", |
There was a problem hiding this comment.
I don't think we should install Husky.
Happy to discuss this but I think husky adds constraints and anyway, if the CI is correctly set up, we won;t push bad code to the repo.
Having husky adds constraints imo (commits are long to run because the stuff has to run, we can't push WIP commit or quickly change branches with "failing" changes...)...
There was a problem hiding this comment.
Ok np, I'm happy to remove it. Was re-using setup from migration repo
There was a problem hiding this comment.
ok super, lets remove it then :)
There was a problem hiding this comment.
seem like it needs to stay, it's a part of the lint-staged installation and also because of what @richtera mentioned:
With yarn >3 you need to do the yarn husky install manually. Yarn no longer executes postinstall code in dependencies due to security.
There was a problem hiding this comment.
lint-staged just speeds up dev by not having to wait a few minutes for results in gitops, but other than that they make things more involved when committing.
| "lint-staged": { | ||
| "*.{ts,js,vue}": [ | ||
| "prettier --list-different", | ||
| "eslint" | ||
| ], |
There was a problem hiding this comment.
I'm not a big fan of this lint staged thing... But up to you.
I rly think a good CI and branch protection is enough.
There was a problem hiding this comment.
But lint staged is important otherwise you cannot partially commit things
There was a problem hiding this comment.
This allow to catch issues earlier then on CI, I guess you can still run it from script but this is nice small automation that helps you not forget. If you are not liking this I will remove.
There was a problem hiding this comment.
It is really up to you, if you think it adds more value than "blocking time" then lets keep it.
You do need the .yarn folder. You can just exclude .yarn/cache if you don't want pnp. |
Yes, |
Ticket ID
DEV-6010
Description
Prepare repo and all deps/configs for new wallet.