Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Repair ipfs decoding when using custom authenticated gateway. #246

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

richtera
Copy link
Contributor

@richtera richtera commented Dec 9, 2023

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

  • fix: Repair IPFS decoding in lsp-factory when using custom authenticated gateway.

What is the current behaviour (you can also link to an open issue here)?

When using custom authenticated gateway the URL decoding for ipfs:// URLs gets confused
because we don't usually defined options.host

What is the new behaviour (if this is a feature change)?

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (bd1bcc7) 19.23% compared to head (2ae904a) 19.07%.

Files Patch % Lines
src/lib/helpers/uploader.helper.ts 0.00% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #246      +/-   ##
===========================================
- Coverage    19.23%   19.07%   -0.17%     
===========================================
  Files           15       15              
  Lines         1071     1080       +9     
  Branches       381      384       +3     
===========================================
  Hits           206      206              
- Misses         843      852       +9     
  Partials        22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CallumGrindle CallumGrindle merged commit f55d0e1 into develop Jan 5, 2024
1 check passed
@CallumGrindle CallumGrindle deleted the fix/repair-ipfs-decode branch January 5, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants