Skip to content

Commit

Permalink
Merge pull request #241 from lukso-network/update-docs-links
Browse files Browse the repository at this point in the history
docs: update links
  • Loading branch information
CallumGrindle authored Nov 27, 2023
2 parents 844cefc + 5474fad commit bd1bcc7
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion docs/classes/lsp7-digital-asset.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ title: LSP7DigitalAsset
lspFactory.LSP7DigitalAsset.deploy(digitalAssetProperties [, options]);
```

Deploys a mintable [LSP7 Digital Asset](../../../standards/nft-2.0/LSP7-Digital-Asset).
Deploys a mintable [LSP7 Digital Asset](../../../standards/tokens/LSP7-Digital-Asset).

:::info

Expand Down
2 changes: 1 addition & 1 deletion docs/classes/lsp8-identifiable-digital-asset.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ title: LSP8IdentifiableDigitalAsset
lspFactory.LSP8IdentifiableDigitalAsset.deploy(digitalAssetProperties [, options]);
```

Deploys a mintable [LSP8 Identifiable Digital Asset](../../../standards/nft-2.0/LSP8-Identifiable-Digital-Asset).
Deploys a mintable [LSP8 Identifiable Digital Asset](../../../standards/tokens/LSP8-Identifiable-Digital-Asset).

:::info

Expand Down
12 changes: 6 additions & 6 deletions docs/deployment/digital-asset.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ Set the address which should own your digital asset contract by passing the `con

### Adding LSP4 Metadata

[LSP7] and [LSP8] both adhere to the [LSP4 Digital Asset Metadata standard](../../../standards/nft-2.0/LSP4-Digital-Asset-Metadata.md). Developers can specify the LSP4Metadata by setting the `name`, `symbol`, `digitalAssetMetadata` and `creators` keys when deploying with LSPFactory.
[LSP7] and [LSP8] both adhere to the [LSP4 Digital Asset Metadata standard](../../../standards/tokens/LSP4-Digital-Asset-Metadata.md). Developers can specify the LSP4Metadata by setting the `name`, `symbol`, `digitalAssetMetadata` and `creators` keys when deploying with LSPFactory.

```javascript
await lspFactory.LSP8IdentifiableDigitalAsset.deploy({
Expand All @@ -128,9 +128,9 @@ await lspFactory.LSP8IdentifiableDigitalAsset.deploy({
});
```

The `name` and `symbol` keys are passed as deployment constructor parameters. These values will set the [`LSP4TokenName`](../../../standards/nft-2.0/LSP4-Digital-Asset-Metadata.md#lsp4tokenname) and [`LSP4TokenSymbol`](../../../standards/nft-2.0/LSP4-Digital-Asset-Metadata.md#lsp4tokensymbol) [ERC725Y] keys directly on the contract during deployment.
The `name` and `symbol` keys are passed as deployment constructor parameters. These values will set the [`LSP4TokenName`](../../../standards/tokens/LSP4-Digital-Asset-Metadata.md#lsp4tokenname) and [`LSP4TokenSymbol`](../../../standards/tokens/LSP4-Digital-Asset-Metadata.md#lsp4tokensymbol) [ERC725Y] keys directly on the contract during deployment.

Addresses passed inside the `creators` array will be set under the [LSP4Creators[]](../../../standards/nft-2.0/LSP4-Digital-Asset-Metadata#lsp4creators) [ERC725Y] key.
Addresses passed inside the `creators` array will be set under the [LSP4Creators[]](../../../standards/tokens/LSP4-Digital-Asset-Metadata#lsp4creators) [ERC725Y] key.

:::warning
LSPFactory does not set the [LSP3IssuedAssets key](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-3-UniversalProfile-Metadata.md#lsp3issuedassets) on any Universal Profile when deploying a digital asset. This key will have to be updated seperately.
Expand All @@ -139,7 +139,7 @@ LSPFactory does not set the [LSP3IssuedAssets key](https://github.com/lukso-netw

#### Digital Asset Metadata

Further Digital Asset metadata can be added by passing the `digitalAssetMetadata` parameter. This is metadata stored as JSON on a server and referenced from the contract by the [`LSP4Metadata`](../../../standards/nft-2.0/LSP4-Digital-Asset-Metadata.md#lsp4metadata) [ERC725Y] key.
Further Digital Asset metadata can be added by passing the `digitalAssetMetadata` parameter. This is metadata stored as JSON on a server and referenced from the contract by the [`LSP4Metadata`](../../../standards/tokens/LSP4-Digital-Asset-Metadata.md#lsp4metadata) [ERC725Y] key.

:::info Info
Digital Asset Metadata can be passed as either a JSON object containing the [LSP4Metadata](https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-4-DigitalAsset-Metadata.md) you want to upload or a URL of your previously uploaded metadata.
Expand Down Expand Up @@ -632,7 +632,7 @@ Digital Asset deployment completed

```

[lsp7]: ../../../standards/nft-2.0/LSP7-Digital-Asset
[lsp8]: ../../../standards/nft-2.0/LSP8-Identifiable-Digital-Asset
[lsp7]: ../../../standards/tokens/LSP7-Digital-Asset
[lsp8]: ../../../standards/tokens/LSP8-Identifiable-Digital-Asset
[erc20]: https://eips.ethereum.org/EIPS/eip-20
[erc725y]: ../../../standards/generic-standards/lsp2-json-schema.md
2 changes: 1 addition & 1 deletion docs/deployment/universal-profile.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Inside the `profileProperties` object, you can set profile configuration options

### Controller Addresses

You can set the addresses which should be able to control your Universal Profile initially by passing in the `controllerAddresses`. The addresses that were passed here will be given all LSP6 KeyManager permissions except `DELEGATECALL` to [prevent accidental misuse](https://solidity-by-example.org/hacks/delegatecall/). If your controller keys require `DELEGATECALL`, you can [change the permission after deployment](../../../guides/key-manager/give-permissions.md).
You can set the addresses which should be able to control your Universal Profile initially by passing in the `controllerAddresses`. The addresses that were passed here will be given all LSP6 KeyManager permissions except `DELEGATECALL` to [prevent accidental misuse](https://solidity-by-example.org/hacks/delegatecall/). If your controller keys require `DELEGATECALL`, you can [change the permission after deployment](../../../learn/expert-guides/key-manager/grant-permissions.md).

The property `controllerAddresses` can be filled with addresses of externally owned accounts (EOAs) or another smart contract that can call the `execute(calldata)` function on the KeyManager.

Expand Down

0 comments on commit bd1bcc7

Please sign in to comment.