Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OP permission fallback #27

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix OP permission fallback #27

merged 1 commit into from
Oct 28, 2024

Conversation

DrexHD
Copy link
Contributor

@DrexHD DrexHD commented Oct 26, 2024

  • Uses ServerPlayerEntity specific getCommandSource method to fix op fallback, see Wesleys's comment.
  • Throws an appropriate error if the permission api is invoked with a non server side entity, see my comment.

@DrexHD @lucko
Fix OP permission fallback
d9b175f 
- Uses ServerPlayerEntity specific getCommandSource method.
- Throws an appropriate error if the permission api is invoked by a non
server side entity
@lucko
Copy link
Owner

lucko commented Oct 28, 2024

Thanks :)

@lucko lucko merged commit e3f1900 into lucko:master Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrexHD @lucko