Allow HTTP and HTTP servers to be turned off #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will (probably) be useful for those people using pizauth on a remote machine accessed via ssh.
|
Not sure if I'm doing something wrong. to my config. However, no error is shown on The same appears if one of |
|
|
|
Just tested, works for me. However I feel its a bit missleading to be without quotes, as everything else is with quotes, but I don't see a better solution either. |
|
Would another keyword have made it clearer? I'm open to suggestions. |
|
What about using |
Good idea! Fixed in 925b5a1. Does that still work for you? |
The main use case for this is someone who wants to ensure that only the HTTPS server is active (i.e. that they can't accidentally connect via HTTP). But making both of them optional keeps the system more consistent, and someone might have a use for running the HTTP but not the HTTPS server!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main commit here is e4ed00a, which allows one to set e.g.
http_listen = offglobally to ensure that only the HTTPS server is running. Both HTTP and HTTPS servers default to on.@trembel Might you be able to test this and see if it works correctly in your setup?