Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IF NOT EXIST to a migration ALTER monitor #5154

Conversation

damyanmp
Copy link

@damyanmp damyanmp commented Oct 3, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #(#5151)

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@damyanmp damyanmp changed the title Adding IF NOT EXIST to the query Adding IF NOT EXIST to a migration ALTER monitor Oct 3, 2024
@damyanmp
Copy link
Author

damyanmp commented Oct 3, 2024

By using IF NOT EXISTS, you avoid the need to manually check whether the column exists, reducing the complexity of migration scripts and error-handling logic. @louislam

@louislam louislam added the question Further information is requested label Oct 3, 2024
@CommanderStorm
Copy link
Collaborator

The collum should not exist beforehand
=> something else must have gone wrong such as a botched migration to a newer version or something else.

Given that thus this does not solve the issue (just the symptom in your specific case) I don't want to add this.
If the assumptions of the migration (f.ex. in this case that the collum does not exist) was broken, this should cause an error.

@damyanmp damyanmp deleted the adding-column-key-check-on-migration branch October 17, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants