-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Incident report History #4943
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as spam.
This comment was marked as spam.
if Incident history configurable to be visible on the status page would be even better |
definitely able to add this later on just trying to ge tthe base feature out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The status page currently manages incidents.
I would prefer to leave this as a status page concept and add the history there instead.
Having this as a concept like maintenance has advantages and downsides. Without the infra needed, this is currently somewhat confusing to new users as they have likely not figured out where incidents can be created.
If you want to add this to the admin UI as well, this needs better UX from this side. (split error+empty, add a helptext that incidents can be created on status pages)
src/pages/ListIncidents.vue
Outdated
this.isLoading = false; | ||
} | ||
}, | ||
formatDate(dateString) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use the time handling mixin instead
See https://github.com/louislam/uptime-kuma/blob/master/src/mixins/datetime.js
src/pages/ListIncidents.vue
Outdated
@@ -0,0 +1,87 @@ | |||
<template> | |||
<div> | |||
<h1>Incident Reports</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, our transaltors could not translate this string.
Please use {{ $t("Incident Reports") }}
instead and add this key to the en.json
.
There are a few other cases of this as well
ok understandable i can do all of this however im not a ui-ux designer would you be able to more in depth describe how this should look |
There are a few designs in |
alot of enterprise solutions look something along the lines of this https://jira-service-management.status.atlassian.com/ would you be willing to use this or no? |
I think you are talking about the difference of having the incident history on a separate page vs on the same page but below. I would prefer that to be tucked away on a separeate page (I suspect that the regular user does not need to have this avaliable) and linked from the page, but if it is below that is fine by me. |
sounds good i will fix it up and put it on the status page instead |
@CommanderStorm what do we think of it now... good to merge? |
whats the status of this pr im considering closing and reopening |
Sorry Also: the API you are calling does not exist => have you tested the code?... If you are asking about a merge or reject decision, that would be close, but things are not final.. the issues left are fixable, but require work.. |
ok i will fix this up again thank you very much for understanding |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Added Incident Report History for the #1100
Fixes #1100
Type of change
Feature addition
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
Incident report history list
Incident report history button