Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Update CI steps to build the app #158

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

Zaid-maker
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #(issue)

Type of change

Please delete any options that are not relevant.

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@Zaid-maker
Copy link
Contributor Author

pnpm is fast tho 10s to build the app DAMN!

@louislam louislam merged commit d1d3a54 into louislam:master Nov 23, 2023
4 checks passed
@louislam
Copy link
Owner

pnpm is fast tho 10s to build the app DAMN!

If you meant build:frontend, it is vite 5.0. It is just released a week ago.

https://vitejs.dev/blog/announcing-vite5

But pnpm install is amazing of course.

@Zaid-maker Zaid-maker deleted the update-ci branch November 23, 2023 08:26
@Zaid-maker
Copy link
Contributor Author

pnpm is fast tho 10s to build the app DAMN!

If you meant build:frontend, it is vite 5.0. It is just released a week ago.

https://vitejs.dev/blog/announcing-vite5

But pnpm install is amazing of course.

No doubt its amazing! 😄 can we update vite on uptime kuma aswell 👀

@louislam
Copy link
Owner

pnpm is fast tho 10s to build the app DAMN!

If you meant build:frontend, it is vite 5.0. It is just released a week ago.
https://vitejs.dev/blog/announcing-vite5
But pnpm install is amazing of course.

No doubt its amazing! 😄 can we update vite on uptime kuma aswell 👀

Unfortunately , npm is used for update/install for non-Docker users, and pnpm is not using the same lock file.

I don't think it is possible to ask everyone to switch to pnpm and don't want to confuse current non-Docker users, so it is not a good idea to switch to pnpm in the middle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants