feat(fabric8io#1382): Adds NPE check and throw an exception in case o…

…f error
lordofthejars · Oct 2, 2018 · 5509b99 · 5509b99
1 parent 8e0a22c
commit 5509b99
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/core/src/main/java/io/fabric8/maven/core/config/MappingConfig.java b/core/src/main/java/io/fabric8/maven/core/config/MappingConfig.java
@@ -22,7 +22,7 @@ public String[] getFilenamesAsArray() {
     }
 
     public boolean isValid() {
-        return kind != null &&  filenameTypes.length() > 0;
+        return kind != null &&  filenameTypes != null && filenameTypes.length() > 0;
     }
 
 }
diff --git a/plugin/src/main/java/io/fabric8/maven/plugin/mojo/build/ResourceMojo.java b/plugin/src/main/java/io/fabric8/maven/plugin/mojo/build/ResourceMojo.java
@@ -433,6 +433,9 @@ private void updateKindFilenameMappings() {
             for(MappingConfig mappingConfig : this.mappings) {
                 if (mappingConfig.isValid()) {
                     mappingKindFilename.put(mappingConfig.getKind(), Arrays.asList(mappingConfig.getFilenamesAsArray()));
+                } else {
+                    throw new IllegalArgumentException(String.format("Invalid mapping for Kind %s and Filename Types %s",
+                        mappingConfig.getKind(), mappingConfig.getFilenameTypes()));
                 }
             }
             KubernetesResourceUtil.updateKindFilenameMapper(mappingKindFilename);