Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish v2 frontend design #219

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Polish v2 frontend design #219

wants to merge 4 commits into from

Conversation

evtyz
Copy link
Member

@evtyz evtyz commented Aug 23, 2021

Purpose: Closes #216.

@vercel
Copy link

vercel bot commented Aug 23, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/loo-labs/waterpark/6uut5xLgwydnjhvrJARjyp57z3RL
✅ Preview: https://waterpark-git-216-polish-design-loo-labs.vercel.app

@evtyz evtyz changed the title Polish v2 design (#216) Polish v2 frontend design Aug 23, 2021
@jeffzh4ng jeffzh4ng temporarily deployed to waterpark-216-polish-de-xue1wb August 23, 2021 20:34 Inactive
@jeffzh4ng jeffzh4ng temporarily deployed to waterpark-216-polish-de-xue1wb August 23, 2021 20:40 Inactive
@jeffzh4ng jeffzh4ng temporarily deployed to waterpark-216-polish-de-xue1wb August 23, 2021 21:23 Inactive
@jeffzh4ng jeffzh4ng temporarily deployed to waterpark-216-polish-de-xue1wb August 23, 2021 21:53 Inactive
@jeffzh4ng jeffzh4ng marked this pull request as ready for review August 28, 2021 18:43
@jeffzh4ng
Copy link
Member

jeffzh4ng commented Aug 28, 2021 •
edited
Loading

@evtyz marked this for ready for review by accident soz

@CarolinaLi
Copy link
Member

nice search bar updates! a few nits:

  • can we use "sort by"?
  • realized that I should've made "sort by:" and "alphabetical" different styling to help separate them. can we update the colour of "sort by:" to grey, like the search icon?
  • can we also update the outline and the dropdown arrow to the same grey?
  • would be nice to make "Alphabetical" bold
  • on smaller screen sizes, it looks like the dropdown arrow is in the middle of the bar, can we anchor it to the right?
    image

xujustinj
xujustinj reviewed Sep 11, 2021
View reviewed changes
Copy link
Member

@xujustinj xujustinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

noticing a weird UI issue on narrow screens (~250px), not sure if we want to bother fixing it

client/components/resource-details/Gallery.tsx
@@ -30,6 +30,7 @@ export const Gallery = styled(
/>
)
}}
// thumbnailPosition={'right'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// thumbnailPosition={'right'}

client/components/resource-details/Reviews.tsx
@@ -94,7 +94,7 @@ const Comment = styled(({ className, review }: { className?: string; review: Rev
<div className={className}>
<Description>{review.comment}</Description>
<AuthorInfo>
— {review.faculty} {review.status}, {formatRelative(review.timestamp, Date.now())}
— {review.faculty} {review.status}, {formatDistanceToNowStrict(review.timestamp)} ago
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xujustinj xujustinj xujustinj left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polish v2 frontend design
5 participants
@evtyz @jeffzh4ng @CarolinaLi @xujustinj @a22yuen