Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't test with XFS volumes smaller than 300 MiB #1885

Merged
merged 2 commits into from
May 8, 2024
Merged

Don't test with XFS volumes smaller than 300 MiB #1885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9faa719
Don't test with XFS volumes smaller than 300 MiB
ejweber May 6, 2024
3f43589
Merge branch 'master' into 8488-xfs-300mib-xfs-min
khushboo-rancher May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion manager/integration/tests/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
Gi = (1024 * Mi)

SIZE = str(16 * Mi)
# See https://github.com/longhorn/longhorn/issues/8488.
XFS_MIN_SIZE = str(300 * Mi)
EXPAND_SIZE = str(32 * Mi)
VOLUME_NAME = "longhorn-testvol"
ATTACHMENT_TICKET_ID_PREFIX = "test-attachment-ticket"
Expand Down Expand Up @@ -5127,7 +5129,7 @@ def crash_engine_process_with_sigkill(client, core_api, volume_name):

kill_command = [
'/bin/sh', '-c',
"kill `pgrep -f \"controller " + volume_name + "\"`",]
"kill `pgrep -f \"controller " + volume_name + "\"`"]

with timeout(seconds=STREAM_EXEC_TIMEOUT,
error_message='Timeout on executing stream read'):
Expand Down
5 changes: 3 additions & 2 deletions manager/integration/tests/test_csi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from common import SETTING_REPLICA_NODE_SOFT_ANTI_AFFINITY
from common import SETTING_REPLICA_REPLENISHMENT_WAIT_INTERVAL
from common import LONGHORN_NAMESPACE
from common import XFS_MIN_SIZE
from common import create_and_wait_pod, create_pvc_spec, delete_and_wait_pod
from common import size_to_string, create_storage_class, create_pvc
from common import create_crypto_secret
Expand Down Expand Up @@ -610,7 +611,7 @@ def test_xfs_pv(client, core_api, pod_manifest): # NOQA
"""
volume_name = generate_volume_name()

volume = create_and_check_volume(client, volume_name)
volume = create_and_check_volume(client, volume_name, size=XFS_MIN_SIZE)

create_pv_for_volume(client, core_api, volume, volume_name, "xfs")

Expand Down Expand Up @@ -648,7 +649,7 @@ def test_xfs_pv_existing_volume(client, core_api, pod_manifest): # NOQA
"""
volume_name = generate_volume_name()

volume = create_and_check_volume(client, volume_name)
volume = create_and_check_volume(client, volume_name, size=XFS_MIN_SIZE)

create_pv_for_volume(client, core_api, volume, volume_name, "xfs")

Expand Down