Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(robot): migrate test_snapshot test case #1861

Merged
merged 2 commits into from
May 3, 2024

Conversation

yangchiu
Copy link
Member

Which issue(s) this PR fixes:

Issue longhorn/longhorn#8259

What this PR does / why we need it:

migrate test_snapshot test case

Special notes for your reviewer:

Additional documentation or context

@yangchiu yangchiu self-assigned this Apr 13, 2024
@yangchiu yangchiu requested a review from a team as a code owner April 13, 2024 07:02
e2e/tests/regression/test_basic.robot Outdated Show resolved Hide resolved
@yangchiu yangchiu force-pushed the migrate-test-snapshot branch 3 times, most recently from 8aa144b to e3de370 Compare April 17, 2024 06:33
@yangchiu yangchiu requested review from c3y1huang and a team April 17, 2024 06:34
e2e/keywords/volume.resource Outdated Show resolved Hide resolved
e2e/libs/snapshot/rest.py Outdated Show resolved Hide resolved
e2e/libs/utility/utility.py Outdated Show resolved Hide resolved
e2e/tests/regression/test_basic.robot Outdated Show resolved Hide resolved
e2e/tests/regression/test_basic.robot Outdated Show resolved Hide resolved
e2e/tests/regression/test_basic.robot Show resolved Hide resolved
Copy link

mergify bot commented Apr 19, 2024

This pull request is now in conflict. Could you fix it @yangchiu? 🙏

e2e/libs/snapshot/base.py Show resolved Hide resolved
e2e/libs/volume/base.py Show resolved Hide resolved
Copy link

mergify bot commented Apr 25, 2024

This pull request is now in conflict. Could you fix it @yangchiu? 🙏

@yangchiu yangchiu force-pushed the migrate-test-snapshot branch 2 times, most recently from 0ae7d39 to 1583621 Compare April 30, 2024 07:28
Copy link

mergify bot commented Apr 30, 2024

This pull request is now in conflict. Could you fix it @yangchiu? 🙏

@yangchiu yangchiu force-pushed the migrate-test-snapshot branch 2 times, most recently from fd8234b to 9d1fcc3 Compare April 30, 2024 08:53
Copy link

mergify bot commented May 1, 2024

This pull request is now in conflict. Could you fix it @yangchiu? 🙏

Copy link

mergify bot commented May 2, 2024

This pull request is now in conflict. Could you fix it @yangchiu? 🙏

Copy link
Contributor

@chriscchien chriscchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, went through the code and did not have any concern.

@yangchiu yangchiu merged commit ef452b2 into longhorn:master May 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants