Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add events when pre- or post-upgrade check fails (backport #3211) #3219

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 18, 2024

Which issue(s) this PR fixes:

longhorn/longhorn#9643, backport issue for longhorn/longhorn#9569

What this PR does / why we need it:

Add an event when upgrade pre- or post-check job completes, either with error or success message.

Special notes for your reviewer:

Additional documentation or context

Summary by CodeRabbit

  • New Features

    • Enhanced event broadcasting and recording capabilities during the upgrade process.
    • Improved logging for pre-upgrade checks and outcomes.
  • Bug Fixes

    • Simplified event handling by streamlining the event broadcaster functionality.
  • Documentation

    • Updated comments for better clarity on upgrade path checks.

This is an automatic backport of pull request #3211 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Oct 18, 2024
Copy link
Author

mergify bot commented Oct 18, 2024

Cherry-pick of e6ce3f2 has failed:

On branch mergify/bp/v1.7.x/pr-3211
Your branch is up to date with 'origin/v1.7.x'.

You are currently cherry-picking commit e6ce3f26.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   app/post_upgrade.go
	modified:   app/pre_upgrade.go
	modified:   app/recurring_job.go
	new file:   app/util.go
	modified:   constant/events.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   upgrade/upgrade.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@derekbit
Copy link
Member

Will merge it after v1.7.2 is out

@derekbit derekbit marked this pull request as draft October 18, 2024 00:29
@derekbit
Copy link
Member

@james-munson Found some conflicts.

Signed-off-by: James Munson <[email protected]>
(cherry picked from commit e6ce3f2)

# Conflicts:
#	upgrade/upgrade.go
@james-munson james-munson marked this pull request as ready for review October 18, 2024 16:31
@james-munson
Copy link
Contributor

Fixed conflicts and re-based. Ready to go.

@PhanLe1010 PhanLe1010 merged commit d4b6a98 into v1.7.x Oct 18, 2024
7 checks passed
@PhanLe1010 PhanLe1010 deleted the mergify/bp/v1.7.x/pr-3211 branch October 18, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants