Feat/hash cmd (hset/hget hmset/hmset) #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lqxhub
reviewed
Nov 24, 2023
| HSetCmd::HSetCmd(const std::string& name, int16_t arity) | ||
| : BaseCmd(name, arity, CmdFlagsWrite, AclCategoryWrite | AclCategoryHash) {} | ||
|
|
||
| bool HSetCmd::DoInitial(PClient* client) { return true; } |
There was a problem hiding this comment.
这里要把操作的key 放到client里, client->setkey() 下面那几个命令同样
There was a problem hiding this comment.
这个我看cmd_kv有，但是不太理解这一步的作用
| } | ||
| return; | ||
| } | ||
| client->AppendContent(reply.ReadStringWithoutCRLF()); |
There was a problem hiding this comment.
client里有一个 AppendStringRaw 可以直接设置字符串, 不用ReadStringWithoutCRLF() 去除 \r\n
|
|
||
| void HSetCmd::DoCmd(PClient* client) { | ||
| UnboundedBuffer reply; | ||
| std::vector<std::string> params(client->argv_.begin(), client->argv_.end()); |
There was a problem hiding this comment.
client->argv_.begin() argv的第一个是 命令名, 这里就是 hset, 要把这个排除
There was a problem hiding this comment.
但是在hash.cc:hset()这个函数里，我看要包含命令本身
| HMSetCmd::HMSetCmd(const std::string& name, int16_t arity) | ||
| : BaseCmd(name, arity, CmdFlagsWrite, AclCategoryWrite | AclCategoryHash) {} | ||
|
|
||
| bool HMSetCmd::DoInitial(PClient* client) { return true; } |
There was a problem hiding this comment.
这里也是需要把key放到client里, 这里参数长度是变长的, 应该判断一下 k v 的数量是否是2的倍数, 也是就是 field和value是否 对应
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.