Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tag <rondb-version>-latest (#89) #90

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Remove tag <rondb-version>-latest (#89) #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 9 additions & 25 deletions .github/workflows/build_test_push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,23 +223,14 @@ jobs:
--build-arg RONDB_TARBALL_LOCAL_REMOTE=remote \
--build-arg RONDB_X86_TARBALL_URI=${{ inputs.base_download_url }}/${{ inputs.rondb_x86_tarball_name }}

- name: Push standard versioned image
- name: Push versioned image
if: github.repository == 'logicalclocks/rondb-docker' && (startsWith(github.ref_name, 'release-') || github.ref_name == 'main')
run: |
NEW_IMAGE_ID=hopsworks/$X86_IMAGE_ID

docker tag $X86_IMAGE_ID $NEW_IMAGE_ID
docker push $NEW_IMAGE_ID

- name: Push with tag `<rondb-version>-latest`
# Our "latest" branch points to the latest *release* branch.
if: needs.process-info.outputs.is_highest_release == 'true'
run: |
NEW_IMAGE_ID=hopsworks/$X86_IMAGE_NAME:${{ inputs.rondb_version }}-latest

docker tag $X86_IMAGE_ID $NEW_IMAGE_ID
docker push $NEW_IMAGE_ID

- name: Push with tag `latest`
if: ${{ needs.process-info.outputs.is_highest_release == 'true' && inputs.is_latest_rondb_release }}
run: |
Expand Down Expand Up @@ -276,11 +267,9 @@ jobs:
ARM_IMAGE_NAME="${{ needs.process-info.outputs.arm_image_name }}"

TAGS="--tag hopsworks/$ARM_IMAGE_NAME:${{ inputs.rondb_version }}-$VERSION"
if [[ "${{ needs.process-info.outputs.is_highest_release }}" == "true" ]]; then
TAGS+=" --tag hopsworks/$ARM_IMAGE_NAME:${{ inputs.rondb_version }}-latest"
if [[ "${{ inputs.is_latest_rondb_release }}" == "true" ]]; then
TAGS+=" --tag hopsworks/$ARM_IMAGE_NAME:latest"
fi
if [[ "${{ needs.process-info.outputs.is_highest_release }}" == "true" &&
"${{ inputs.is_latest_rondb_release }}" == "true" ]]; then
TAGS+=" --tag hopsworks/$ARM_IMAGE_NAME:latest"
fi

docker buildx build . \
Expand Down Expand Up @@ -332,16 +321,11 @@ jobs:
hopsworks/$X86_IMAGE_NAME:${{ inputs.rondb_version }}-$VERSION \
hopsworks/$ARM_IMAGE_NAME:${{ inputs.rondb_version }}-$VERSION

if [[ "${{ needs.process-info.outputs.is_highest_release }}" == "true" ]]; then
docker buildx imagetools create -t $repo_url/hopsworks/$MULTI_IMAGE_NAME:${{ inputs.rondb_version }}-latest \
hopsworks/$X86_IMAGE_NAME:${{ inputs.rondb_version }}-latest \
hopsworks/$ARM_IMAGE_NAME:${{ inputs.rondb_version }}-latest

if [[ "${{ inputs.is_latest_rondb_release }}" == "true" ]]; then
docker buildx imagetools create -t $repo_url/hopsworks/$MULTI_IMAGE_NAME:latest \
hopsworks/$X86_IMAGE_NAME:latest \
hopsworks/$ARM_IMAGE_NAME:latest
fi
if [[ "${{ needs.process-info.outputs.is_highest_release }}" == "true" &&
"${{ inputs.is_latest_rondb_release }}" == "true" ]]; then
docker buildx imagetools create -t $repo_url/hopsworks/$MULTI_IMAGE_NAME:latest \
hopsworks/$X86_IMAGE_NAME:latest \
hopsworks/$ARM_IMAGE_NAME:latest
fi

done