[FSTORE-1475] fix partial FG deletion (#1540)

logicalclocks · Jul 31, 2024 · 29d2bfe · 29d2bfe
1 parent 4a112ff
commit 29d2bfe
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/...ain/java/io/hops/hopsworks/common/commands/featurestore/search/SearchFSCommandLogger.java b/...ain/java/io/hops/hopsworks/common/commands/featurestore/search/SearchFSCommandLogger.java
@@ -154,7 +154,10 @@ private SearchFSCommand getCommand(Featuregroup featureGroup, SearchFSCommandOp
  command.setInodeId(inode.getId());
  command.setProject(featureGroup.getFeaturestore().getProject());
  command.setStatus(CommandStatus.NEW);
- command.setFeatureGroup(featureGroup);
+ if (!SearchFSCommandOp.DELETE_ARTIFACT.equals(op)) {
+ // Don't set it since a separate transaction deletes FG, this could cause it to be potentially recreated
+ command.setFeatureGroup(featureGroup);
+ }
  command.setOp(op);
  return command;
  }
@@ -171,7 +174,10 @@ private SearchFSCommand getCommand(FeatureView featureView, SearchFSCommandOp op
  command.setInodeId(inode.getId());
  command.setProject(featureView.getFeaturestore().getProject());
  command.setStatus(CommandStatus.NEW);
- command.setFeatureView(featureView);
+ if (!SearchFSCommandOp.DELETE_ARTIFACT.equals(op)) {
+ // Don't set it since a separate transaction deletes FV, this could cause it to be potentially recreated
+ command.setFeatureView(featureView);
+ }
  command.setOp(op);
  return command;
  }
@@ -194,7 +200,10 @@ private SearchFSCommand getCommand(TrainingDataset trainingDataset, SearchFSComm
  command.setInodeId(inode.getId());
  command.setProject(trainingDataset.getFeaturestore().getProject());
  command.setStatus(CommandStatus.NEW);
- command.setTrainingDataset(trainingDataset);
+ if (!SearchFSCommandOp.DELETE_ARTIFACT.equals(op)) {
+ // Don't set it since a separate transaction deletes TD, this could cause it to be potentially recreated
+ command.setTrainingDataset(trainingDataset);
+ }
  command.setOp(op);
  return command;
  }