Support for BsonDocuments as values, allowing nested documents #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e complex object, convert it to a BsonDocument
|
Ok for me. |
gimmi
reviewed
Oct 24, 2016
| // if the object is complex and can't be mapped to a simple object, convert to bson document | ||
| if (!BsonTypeMapper.TryMapToBsonValue(value, out bsonValue)) | ||
| { | ||
| bsonValue = value.ToBsonDocument(); |
There was a problem hiding this comment.
Isn't the ToBsonDocument() call redundant?
There was a problem hiding this comment.
I don't believe so, since we need a BsonValue type to pass in to the doc.Add() function and an object type doesn't fulfill that. The BsonDocument type is a subclass of BsonValue and so is more specific. Or maybe I'm missing your point all together?
|
Any other opinions on this PR? This seems to be a wanted feature from users and it would be convenient to be able to use the .nuget package instead of having a copy of the source locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BsonValue supports primitive types and ends up converting values to strings. This leads to complex objects being represented within a single value as a string. If the passed in value is a more complex object, convert it to a BsonDocument.
Addresses Issue #38