CAKE-63: Cleanup rkyv dependency management and cleanup dataviews #200
ChillFish8Annotations
50 warnings
|
fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/lib.rs#L586
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/lib.rs:586:38
|
586 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/lib.rs#L529
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/lib.rs:529:38
|
529 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/lib.rs#L469
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/lib.rs:469:38
|
469 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/lib.rs#L404
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/lib.rs:404:38
|
404 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/replication_impl.rs#L274
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/replication_impl.rs:274:49
|
274 | _marker: PhantomData::<MemStore>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/replication_impl.rs#L228
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/replication_impl.rs:228:49
|
228 | _marker: PhantomData::<MemStore>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L233
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:233:42
|
233 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L219
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:219:42
|
219 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L188
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:188:38
|
188 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L158
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:158:38
|
158 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L128
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:128:38
|
128 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L96
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:96:38
|
96 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/replication/poller.rs#L513
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/replication/poller.rs:513:34
|
513 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/replication/poller.rs#L504
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/replication/poller.rs:504:38
|
504 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/replication/poller.rs#L471
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/replication/poller.rs:471:38
|
471 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/keyspace/group.rs#L254
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/keyspace/group.rs:254:69
|
254 | if let Err(e) = state.send(PurgeDeletes(PhantomData::<S>::default())).await {
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
|
|
use of `default` to create a unit struct:
datacake-node/src/lib.rs#L151
warning: use of `default` to create a unit struct
--> datacake-node/src/lib.rs:151:43
|
151 | node_selector: DCAwareSelector::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-node/src/nodes_selector.rs#L544
warning: use of `default` to create a unit struct
--> datacake-node/src/nodes_selector.rs:544:43
|
544 | let mut selector = DCAwareSelector::default();
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
|
|
this `impl` can be derived:
datacake-rpc/src/rkyv_tooling/scratch.rs#L21
warning: this `impl` can be derived
--> datacake-rpc/src/rkyv_tooling/scratch.rs:21:1
|
21 | / impl Default for LazyScratch {
22 | | fn default() -> Self {
23 | | Self {
24 | | stack_scratch: StackScratch::default(),
... |
28 | | }
29 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it
|
15 + #[derive(Default)]
16 | pub struct LazyScratch {
|
|
|
use of `default` to create a unit struct:
datacake-rpc/src/handler.rs#L119
warning: use of `default` to create a unit struct
--> datacake-rpc/src/handler.rs:119:37
|
119 | _msg: PhantomData::<Msg>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/lib.rs#L586
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/lib.rs:586:38
|
586 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/lib.rs#L529
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/lib.rs:529:38
|
529 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/lib.rs#L469
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/lib.rs:469:38
|
469 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/lib.rs#L404
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/lib.rs:404:38
|
404 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L233
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:233:42
|
233 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L219
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:219:42
|
219 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L188
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:188:38
|
188 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L158
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:158:38
|
158 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L128
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:128:38
|
128 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L96
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:96:38
|
96 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/replication/poller.rs#L513
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/replication/poller.rs:513:34
|
513 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/replication/poller.rs#L504
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/replication/poller.rs:504:38
|
504 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/replication/poller.rs#L471
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/replication/poller.rs:471:38
|
471 | _marker: PhantomData::<S>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
datacake-eventual-consistency/src/keyspace/group.rs#L254
warning: use of `default` to create a unit struct
--> datacake-eventual-consistency/src/keyspace/group.rs:254:69
|
254 | if let Err(e) = state.send(PurgeDeletes(PhantomData::<S>::default())).await {
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
|
|
use of `default` to create a unit struct:
datacake-node/src/lib.rs#L151
warning: use of `default` to create a unit struct
--> datacake-node/src/lib.rs:151:43
|
151 | node_selector: DCAwareSelector::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
|
|
this `impl` can be derived:
datacake-rpc/src/rkyv_tooling/scratch.rs#L21
warning: this `impl` can be derived
--> datacake-rpc/src/rkyv_tooling/scratch.rs:21:1
|
21 | / impl Default for LazyScratch {
22 | | fn default() -> Self {
23 | | Self {
24 | | stack_scratch: StackScratch::default(),
... |
28 | | }
29 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it
|
15 + #[derive(Default)]
16 | pub struct LazyScratch {
|
|
|
use of `default` to create a unit struct:
datacake-rpc/src/handler.rs#L119
warning: use of `default` to create a unit struct
--> datacake-rpc/src/handler.rs:119:37
|
119 | _msg: PhantomData::<Msg>::default(),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
|
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, Swatinem/rust-cache@v1, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|