Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #3

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Develop #3

wants to merge 33 commits into from

Conversation

soulnai
Copy link

@soulnai soulnai commented Jan 11, 2015

Please take a look. Not all tests passed, but it's a tests problems, not a library.

pep8==1.5.7
pytest==2.6.4
requests==2.5.0
git+https://github.com/soulnai/gaeenv.git@develop#egg=gaeenv
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this left here by mistake?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for the Travis-CI automatic unit-test runs.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably would make sense to install this from the .travis.yml file instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea. I will change .travis.yml in my fork.

2015-01-16 17:13 GMT+02:00 Lance Linder [email protected]:

In requirements.txt
#3 (diff):

@@ -0,0 +1,5 @@
+mock==1.0.1
+pep8==1.5.7
+pytest==2.6.4
+requests==2.5.0
+git+https://github.com/soulnai/gaeenv.git@develop#egg=gaeenv

probably would make sense to install this from the .travis.yml file
instead.


Reply to this email directly or view it on GitHub
https://github.com/llinder/gaeenv/pull/3/files#r23085243.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I removed requirements.txt and fixed travis.yml.

Also in latest develop branch added support of pip 6.0+ (including packages
installed via git+) if you are interested.

Best regards.

2015-01-17 11:11 GMT+02:00 Александр Васильев [email protected]:

Nice idea. I will change .travis.yml in my fork.

2015-01-16 17:13 GMT+02:00 Lance Linder [email protected]:

In requirements.txt
#3 (diff):

@@ -0,0 +1,5 @@
+mock==1.0.1
+pep8==1.5.7
+pytest==2.6.4
+requests==2.5.0
+git+https://github.com/soulnai/gaeenv.git@develop#egg=gaeenv

probably would make sense to install this from the .travis.yml file
instead.


Reply to this email directly or view it on GitHub
https://github.com/llinder/gaeenv/pull/3/files#r23085243.

@llinder
Copy link
Owner

llinder commented Jan 12, 2015

@soulnai the changes look good to me. thanks again for submitting your changes back to the project. if you can update your pull request I will merge it otherwise I will sort out the conflicts and merge when I get some extra time. thanks!

@soulnai
Copy link
Author

soulnai commented Jan 12, 2015

It's for the Travis-CI automatic unit-test runs.

2015-01-12 5:11 GMT+02:00 Lance Linder [email protected]:

@soulnai https://github.com/soulnai the changes look good to me. thanks
again for submitting your changes back to the project. if you can update
your pull request I will merge it otherwise I will sort out the conflicts
and merge when I get some extra time. thanks!


Reply to this email directly or view it on GitHub
#3 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants