Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enconding presets #464

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix enconding presets #464

wants to merge 1 commit into from

Conversation

iparaskev
Copy link

Fixes an issue with compute_appropriate_encoding, where the last preset in the list with the highest FPS wasn't considered.

Changes the order in into_rtp_encodings to have the highest quality first.

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024

CLA assistant check
All committers have signed the CLA.

@iparaskev
Copy link
Author

Hi, first of all thanks for the project.

I have a question regarding the "rid" when the presets are only 2 in into_rtp_encodings. Should they be

  1. "q" and "h"
  2. "q" and "f"
  3. "h" and "f"

?

Thanks

Fixes an issue with compute_appropriate_encoding, where the last preset
in the list with the highest FPS wasn't considered.

Changes the order in into_rtp_encodings to have the highest quality
first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants