RPC implementation + FFI #461
Merged
+1,441
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theomonnom
reviewed
Oct 23, 2024
theomonnom
reviewed
Oct 23, 2024
theomonnom
reviewed
Oct 23, 2024
theomonnom
reviewed
Oct 23, 2024
theomonnom
reviewed
Oct 23, 2024
livekit/src/rtc_engine/mod.rs
Outdated
Comment on lines
315
to
318
| pub fn get_latest_join_response(&self) -> proto::JoinResponse { | ||
| self.inner.latest_join_response.clone() | ||
| } | ||
| } |
There was a problem hiding this comment.
Seems like this is unused, can you remove
There was a problem hiding this comment.
There was a problem hiding this comment.
The link doesn't work for me
theomonnom
reviewed
Oct 23, 2024
livekit/src/rtc_engine/mod.rs
Outdated
| @@ -167,6 +183,7 @@ struct EngineInner { | |||
| lk_runtime: Arc<LkRuntime>, | |||
| engine_tx: EngineEmitter, | |||
| options: EngineOptions, | |||
| latest_join_response: proto::JoinResponse, | |||
theomonnom
approved these changes
Oct 23, 2024
theomonnom
reviewed
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fully implements the new RPC feature in the Rust SDK and exposes it via FFI to other SDKs.
It has one slight rough edge as there is a new FFI dance necessary for method handling. The
register_rpc_methodFFI cannot store the original handler, so instead it registers a wrapper handler that dispatches into the dependent SDK to actually handle the method and then get a response or error that can be sent back up the wire. So the implementation in Node/Python/Unity/etc requires both storing the handlers locally and forwarding to FFI onregisterRpcMethod. Then it waits forRpcMethodInvocationEventand invokes its stored handlers, sending the response/error inRpcMethodInvocationRequestover FFI.This is my first time working with Rust so lmk if I've done anything particularly wrong. The RpcHandler type in particular feels very complicated but maybe that's just Rust.
Base implementation verified with a new example. FFI implementation verified with Node implementation in livekit/node-sdks#276. Both tested locally and against cloud.