Fix layer dimension calculation logic #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostbyte73
approved these changes
Aug 14, 2023
Merged
biglittlebigben
added a commit
that referenced
this pull request
Aug 17, 2023
This is the v1.1.0 release of the ingress service. This release adds support for pulling media from URLs and fixes source resolution handling
## Changelog
### Added
- Log redacted ingress info and set stereo and disableDTX publication options (#130)
- Add Debug handler with pprof support (#131)
- Report average bitrate in the ingress state (#133)
- Support for GST pipeline debug dot files on the debug handler (#136)
- Support for pulling URLs (#138)
### Fixed
- Do not report instance as available while draining (#124)
- Handle better the case where 2 publishers with the same ingress ID connect to the same ingress instance (#125)
- Check stream key in WHIP DELETE call (#126)
- Make sure handler processes use the same node id as the service (#129)
- Update the WebRTC settings engine to match the sessions parameters (#139)
- Adopt jitter.PopSamples in the WHIP handler (#141)
- Only accept specific file types in url pull (#142)
- Fix layer dimension calculation logic (#143)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change layer dimension calculation logic to respect source spec ratio, and never upscale original frame. Also, prune layers that are too large for the original frame.