Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy README images when generating docs #1299

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Copy README images when generating docs #1299

merged 1 commit into from
Oct 24, 2024

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Oct 24, 2024

This should fix the broken image on top of https://docs.livekit.io/client-sdk-js/

@bcherry bcherry requested a review from lukasIO October 24, 2024 16:57
Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: 502ebc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bcherry bcherry requested a review from kath0la October 24, 2024 16:57
Copy link
Contributor

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 83.94 KB (0%)
dist/livekit-client.umd.js 90.01 KB (0%)

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@bcherry bcherry merged commit cf51a2e into main Oct 24, 2024
3 checks passed
@bcherry bcherry deleted the bcherry/docs-images branch October 24, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants