Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track E2EE key validity on a per index basis #1284

Merged
merged 13 commits into from
Oct 14, 2024

Conversation

hughns
Copy link
Contributor

@hughns hughns commented Oct 11, 2024

Supersedes #1272.

It is based on top of #1283. View diff.

Adds a specific test for scenario described at #1272 (comment).

Incorporates previous review feedback:

  • make the key indices optional and default to currentKeyIndex
  • keep the hasValidKey getter
  • if resetKeyStatus is called without an index argument, reset the key status for all keys

Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: c45d45e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hughns hughns changed the title Track decryption failures per key index Track E2EE key validity on a per index basis Oct 11, 2024
Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, just a couple of nits!

src/e2ee/worker/ParticipantKeyHandler.ts Outdated Show resolved Hide resolved
src/e2ee/worker/ParticipantKeyHandler.ts Outdated Show resolved Hide resolved
@hughns hughns requested a review from lukasIO October 14, 2024 09:12
@lukasIO lukasIO merged commit cbcb593 into livekit:main Oct 14, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants