Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC implementation #1282

Merged
merged 65 commits into from
Oct 24, 2024
Merged

RPC implementation #1282

merged 65 commits into from
Oct 24, 2024

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Oct 9, 2024

This is a full implementation of the native RPC spec .

It includes test, documentation, and a complete in-browser working example.

The example has been tested with a local LiveKit instance and in LiveKit cloud.

Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 1ef832c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 9, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 85.59 KB (+1.97% 🔺)
dist/livekit-client.umd.js 91.65 KB (+1.82% 🔺)

@bcherry bcherry requested a review from lukasIO October 11, 2024 23:38
@bcherry bcherry requested a review from lukasIO October 22, 2024 18:39
src/room/Room.ts Outdated Show resolved Hide resolved
@bcherry bcherry requested a review from lukasIO October 22, 2024 21:00
Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ☁️ 📲 🚀

@bcherry bcherry merged commit 09f031f into main Oct 24, 2024
3 checks passed
@bcherry bcherry deleted the bcherry/rpc branch October 24, 2024 21:51
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants