mimeTypeToVideoCodecString should not throw (#1302)

* mimeTypeToVideoCodecString should not throw The current implementation is not resilient to codecs changes. If a new codec is introduced, previously working code would start failing. * changeset
livekit · Oct 26, 2024 · ed3666d · ed3666d
1 parent 09f031f
commit ed3666d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.changeset/heavy-garlics-greet.md b/.changeset/heavy-garlics-greet.md
@@ -0,0 +1,5 @@
+---
+'livekit-client': patch
+---
+
+fix: mimeTypeToVideoCodecString should not throw
diff --git a/src/room/track/utils.ts b/src/room/track/utils.ts
@@ -9,7 +9,6 @@ import {
   type ScreenShareCaptureOptions,
   type VideoCaptureOptions,
   type VideoCodec,
-  videoCodecs,
 } from './options';
 import type { AudioTrack } from './types';
 
@@ -188,11 +187,7 @@ export function screenCaptureToDisplayMediaStreamOptions(
 }
 
 export function mimeTypeToVideoCodecString(mimeType: string) {
-  const codec = mimeType.split('/')[1].toLowerCase() as VideoCodec;
-  if (!videoCodecs.includes(codec)) {
-    throw Error(`Video codec not supported: ${codec}`);
-  }
-  return codec;
+  return mimeType.split('/')[1].toLowerCase() as VideoCodec;
 }
 
 export function getTrackPublicationInfo<T extends TrackPublication>(