Implement bulk of UEFI protocol needed by linux kernel #423
+1,817
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zhangxp1998
force-pushed
the
dev
branch
2 times, most recently
from
1b40efa
to
fd637d3
Compare
travisg
reviewed
Nov 4, 2024
travisg
requested changes
Nov 4, 2024
|
|
||
| sub x0,x0,16 | ||
| mov x6,sp | ||
| str x6,[x0] |
There was a problem hiding this comment.
should be able to 'str sp,[x0]' directly i believe
There was a problem hiding this comment.
Assembler would not let me. Looks like sp is a special operand which can't be used directly in an str instruction.
|
Looks generally pretty good, just a few changes (such as licenses, etc) and it's at least good enough to not bother other code upstream. |
zhangxp1998
force-pushed
the
dev
branch
2 times, most recently
from
e46a392
to
6137b3b
Compare
This allows us to use an identitiy mapped piece of memory as the heap for UEFI app. UEFI app's allocation would go from this heap.
This help reduce the risk of name collision. As MODULE_DIR/include is automatically added to global includes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.